Skip to content

Rename mul_alpha to multiply_alpha #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waywardmonkeys merged 1 commit into from
Nov 24, 2024
Merged

Rename mul_alpha to multiply_alpha #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ This release has an [MSRV][] of 1.82.

* Add `BLACK`, `WHITE`, and `TRANSPARENT` constants to the color types. ([#64][] by [@waywardmonkeys][])

### Changed

* The `mul_alpha` method was renamed to `multiply_alpha`. ([#65][] by [@waywardmonkeys][])

## [0.1.0][] (2024-11-20)

This release has an [MSRV][] of 1.82.
Expand All @@ -28,6 +32,7 @@ This is the initial release.
[@waywardmonkeys]: https://github.com/waywardmonkeys

[#64]: https://github.com/linebender/color/pull/64
[#65]: https://github.com/linebender/color/pull/65

[Unreleased]: https://github.com/linebender/color/compare/v0.1.0...HEAD
[0.1.0]: https://github.com/linebender/color/releases/tag/v0.1.0
Expand Down
6 changes: 3 additions & 3 deletions color/src/color.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ impl<CS: ColorSpace> AlphaColor<CS> {

/// Multiply alpha by the given factor.
#[must_use]
pub const fn mul_alpha(self, rhs: f32) -> Self {
pub const fn multiply_alpha(self, rhs: f32) -> Self {
let (opaque, alpha) = split_alpha(self.components);
Self::new(add_alpha(opaque, alpha * rhs))
}
Expand Down Expand Up @@ -555,7 +555,7 @@ impl<CS: ColorSpace> PremulColor<CS> {

/// Multiply alpha by the given factor.
#[must_use]
pub const fn mul_alpha(self, rhs: f32) -> Self {
pub const fn multiply_alpha(self, rhs: f32) -> Self {
let (multiplied, alpha) = split_alpha(self.components);
Self::new(add_alpha(CS::LAYOUT.scale(multiplied, rhs), alpha * rhs))
}
Expand Down Expand Up @@ -686,7 +686,7 @@ impl<CS: ColorSpace> core::ops::Sub for AlphaColor<CS> {
/// Multiply components by a scalar.
///
/// For rectangular color spaces, this is equivalent to multiplying
/// alpha, but for cylindrical color spaces, [`PremulColor::mul_alpha`]
/// alpha, but for cylindrical color spaces, [`PremulColor::multiply_alpha`]
/// is the preferred method.
impl<CS: ColorSpace> core::ops::Mul<f32> for PremulColor<CS> {
type Output = Self;
Expand Down