-
Notifications
You must be signed in to change notification settings - Fork 648
Allow to skip signature verification #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e276dfc
ef4debb
96eea77
0a74854
a0e8622
a6670ef
a61c9ae
3eed778
418446d
8cba5de
b3983c6
e6a1849
9fddd97
3715834
9dab4b0
9bafc74
965bf0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,12 +71,12 @@ Good documentation ensures that contributors and users can easily read and under | |
| To generate documentation locally, make sure phpDocumentor is installed, then run: | ||
|
|
||
| ``` | ||
| $ wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.3.1/phpDocumentor.phar | ||
| $ wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.8.1/phpDocumentor.phar | ||
| $ php phpDocumentor.phar run -d src -t docs | ||
| ``` | ||
|
|
||
| ## Contributor license agreement | ||
|
|
||
| When you are sending a pull request and it's a non-trivial change beyond fixing typos, please make sure to sign | ||
| [the ICLA (individual contributor license agreement)](https://cla-assistant.io/line/line-bot-sdk-php). Please | ||
| [contact us](mailto:[email protected]) if you need the CCLA (corporate contributor license agreement). | ||
| [contact us](mailto:[email protected]) if you need the CCLA (corporate contributor license agreement). | ||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recognize this as a workaround, but do you encounter a diff when executing the steps written in the workflow locally?
line-bot-sdk-php/.github/workflows/generate-code.yml
Lines 33 to 57 in e6a1849
If so, this might confuse external contributors too like you, and we should consider measures to ensure stricter version control. For example, https://github.com/line/line-bot-sdk-php/blob/master/CONTRIBUTING.md should be updated.
.... However, since CI provides stable results, could it be that your local version is misaligned...?
@eucyt might help you when you're confused with something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the PHP version I was running locally was outdated. The issue is now resolved, but I plan to keep this change for future troubleshooting.