Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
17 changes: 16 additions & 1 deletion .github/workflows/generate-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
bash tools/gen-oas-client.sh
- name: Update document
run: |
wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.3.1/phpDocumentor.phar
wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.8.1/phpDocumentor.phar
php phpDocumentor.phar run -d src -t docs
- run: |
diff_files=$(git --no-pager diff --name-only)
Expand All @@ -64,6 +64,21 @@ jobs:

echo "DIFF_IS_EMPTY=$([[ -z "$diff_excluding_submodule" ]] && echo 'true' || echo 'false')" >> $GITHUB_ENV
echo "CURRENT_DATETIME=$(date +'%Y%m%d%H%M%S')" >> $GITHUB_ENV

# Save full diff to file and upload artifact
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recognize this as a workaround, but do you encounter a diff when executing the steps written in the workflow locally?

# Install openapi-generator-cli
- run: echo "OPENAPI_GENERATOR_VERSION=7.11.0" >> $GITHUB_ENV
- uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # v4.2.4
id: openapi-generator-cache
env:
cache-name: openapi-generator-cache
with:
path: ~/bin/openapitools
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ env.OPENAPI_GENERATOR_VERSION }}
- if: steps.openapi-generator-cache.outputs.cache-hit != 'true'
run: |
mkdir -p ~/bin/openapitools
curl https://raw.githubusercontent.com/OpenAPITools/openapi-generator/master/bin/utils/openapi-generator-cli.sh > ~/bin/openapitools/openapi-generator-cli
chmod u+x ~/bin/openapitools/openapi-generator-cli
export PATH=$PATH:~/bin/openapitools/
OPENAPI_GENERATOR_VERSION=${{ env.OPENAPI_GENERATOR_VERSION }} openapi-generator-cli version
- name: Generate codes
run: |
export PATH=$PATH:~/bin/openapitools/
bash tools/gen-oas-client.sh
- name: Update document
run: |
wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.3.1/phpDocumentor.phar
php phpDocumentor.phar run -d src -t docs

If so, this might confuse external contributors too like you, and we should consider measures to ensure stricter version control. For example, https://github.com/line/line-bot-sdk-php/blob/master/CONTRIBUTING.md should be updated.

.... However, since CI provides stable results, could it be that your local version is misaligned...?
@eucyt might help you when you're confused with something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the PHP version I was running locally was outdated. The issue is now resolved, but I plan to keep this change for future troubleshooting.

- name: Save full diff to file
if: env.DIFF_IS_EMPTY != 'true'
run: |
git --no-pager diff HEAD > diff.patch
echo "Full diff saved to diff.patch"

- name: Upload diff artifact
if: env.DIFF_IS_EMPTY != 'true'
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: codegen-diff
path: diff.patch

## Run if diff exists and pull request or merge queue, and make CI status failure (but allow renovate bot)
- if: >-
${{
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ Good documentation ensures that contributors and users can easily read and under
To generate documentation locally, make sure phpDocumentor is installed, then run:

```
$ wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.3.1/phpDocumentor.phar
$ wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.8.1/phpDocumentor.phar
$ php phpDocumentor.phar run -d src -t docs
```

## Contributor license agreement

When you are sending a pull request and it's a non-trivial change beyond fixing typos, please make sure to sign
[the ICLA (individual contributor license agreement)](https://cla-assistant.io/line/line-bot-sdk-php). Please
[contact us](mailto:[email protected]) if you need the CCLA (corporate contributor license agreement).
[contact us](mailto:[email protected]) if you need the CCLA (corporate contributor license agreement).
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ https://line.github.io/line-bot-sdk-php/

This library provides PHPDoc to describe how to use the methods. You can generate the documentation using phpDocumenter using the following command.

$ wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.3.1/phpDocumentor.phar
$ wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.8.1/phpDocumentor.phar
$ php phpDocumentor.phar run -d src -t docs
The HTML files are generated in docs/.

Expand Down
1,304 changes: 899 additions & 405 deletions docs/classes/LINE-Clients-ChannelAccessToken-Api-ChannelAccessTokenApi.html

Large diffs are not rendered by default.

362 changes: 255 additions & 107 deletions docs/classes/LINE-Clients-ChannelAccessToken-ApiException.html

Large diffs are not rendered by default.

1,000 changes: 712 additions & 288 deletions docs/classes/LINE-Clients-ChannelAccessToken-Configuration.html

Large diffs are not rendered by default.

372 changes: 260 additions & 112 deletions docs/classes/LINE-Clients-ChannelAccessToken-HeaderSelector.html

Large diffs are not rendered by default.

Large diffs are not rendered by default.

894 changes: 624 additions & 270 deletions docs/classes/LINE-Clients-ChannelAccessToken-Model-ErrorResponse.html

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

374 changes: 260 additions & 114 deletions docs/classes/LINE-Clients-ChannelAccessToken-Model-ModelInterface.html

Large diffs are not rendered by default.

Large diffs are not rendered by default.

496 changes: 355 additions & 141 deletions docs/classes/LINE-Clients-ChannelAccessToken-ObjectSerializer.html

Large diffs are not rendered by default.

970 changes: 673 additions & 297 deletions docs/classes/LINE-Clients-Insight-Api-InsightApi.html

Large diffs are not rendered by default.

362 changes: 255 additions & 107 deletions docs/classes/LINE-Clients-Insight-ApiException.html

Large diffs are not rendered by default.

1,000 changes: 712 additions & 288 deletions docs/classes/LINE-Clients-Insight-Configuration.html

Large diffs are not rendered by default.

372 changes: 260 additions & 112 deletions docs/classes/LINE-Clients-Insight-HeaderSelector.html

Large diffs are not rendered by default.

1,091 changes: 741 additions & 350 deletions docs/classes/LINE-Clients-Insight-Model-AgeTile.html

Large diffs are not rendered by default.

947 changes: 657 additions & 290 deletions docs/classes/LINE-Clients-Insight-Model-AppTypeTile.html

Large diffs are not rendered by default.

894 changes: 624 additions & 270 deletions docs/classes/LINE-Clients-Insight-Model-AreaTile.html

Large diffs are not rendered by default.

894 changes: 624 additions & 270 deletions docs/classes/LINE-Clients-Insight-Model-ErrorDetail.html

Large diffs are not rendered by default.

896 changes: 625 additions & 271 deletions docs/classes/LINE-Clients-Insight-Model-ErrorResponse.html

Large diffs are not rendered by default.

947 changes: 657 additions & 290 deletions docs/classes/LINE-Clients-Insight-Model-GenderTile.html

Large diffs are not rendered by default.

1,032 changes: 721 additions & 311 deletions docs/classes/LINE-Clients-Insight-Model-GetFriendsDemographicsResponse.html

Large diffs are not rendered by default.

930 changes: 649 additions & 281 deletions docs/classes/LINE-Clients-Insight-Model-GetMessageEventResponse.html

Large diffs are not rendered by default.

996 changes: 696 additions & 300 deletions docs/classes/LINE-Clients-Insight-Model-GetMessageEventResponseClick.html

Large diffs are not rendered by default.

1,236 changes: 865 additions & 371 deletions docs/classes/LINE-Clients-Insight-Model-GetMessageEventResponseMessage.html

Large diffs are not rendered by default.

1,064 changes: 744 additions & 320 deletions docs/classes/LINE-Clients-Insight-Model-GetMessageEventResponseOverview.html

Large diffs are not rendered by default.

1,015 changes: 705 additions & 310 deletions docs/classes/LINE-Clients-Insight-Model-GetNumberOfFollowersResponse.html

Large diffs are not rendered by default.

Large diffs are not rendered by default.

930 changes: 649 additions & 281 deletions docs/classes/LINE-Clients-Insight-Model-GetStatisticsPerUnitResponse.html

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

374 changes: 260 additions & 114 deletions docs/classes/LINE-Clients-Insight-Model-ModelInterface.html

Large diffs are not rendered by default.

995 changes: 685 additions & 310 deletions docs/classes/LINE-Clients-Insight-Model-SubscriptionPeriodTile.html

Large diffs are not rendered by default.

496 changes: 355 additions & 141 deletions docs/classes/LINE-Clients-Insight-ObjectSerializer.html

Large diffs are not rendered by default.

850 changes: 588 additions & 262 deletions docs/classes/LINE-Clients-Liff-Api-LiffApi.html

Large diffs are not rendered by default.

362 changes: 255 additions & 107 deletions docs/classes/LINE-Clients-Liff-ApiException.html

Large diffs are not rendered by default.

1,000 changes: 712 additions & 288 deletions docs/classes/LINE-Clients-Liff-Configuration.html

Large diffs are not rendered by default.

372 changes: 260 additions & 112 deletions docs/classes/LINE-Clients-Liff-HeaderSelector.html

Large diffs are not rendered by default.

1,032 changes: 721 additions & 311 deletions docs/classes/LINE-Clients-Liff-Model-AddLiffAppRequest.html

Large diffs are not rendered by default.

860 changes: 600 additions & 260 deletions docs/classes/LINE-Clients-Liff-Model-AddLiffAppResponse.html

Large diffs are not rendered by default.

862 changes: 601 additions & 261 deletions docs/classes/LINE-Clients-Liff-Model-GetAllLiffAppsResponse.html

Large diffs are not rendered by default.

1,066 changes: 745 additions & 321 deletions docs/classes/LINE-Clients-Liff-Model-LiffApp.html

Large diffs are not rendered by default.

Loading