Add 'node:' prefix explicitly to import built-in modules #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokuhirom
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
LGTM
ref: bun/deno compatibility
https://docs.deno.com/runtime/manual/node/compatibility
https://bun.sh/docs/runtime/nodejs-apis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Node.js v18 allows us to use
node:prefix to import built-in modules. line-bot-sdk-nodejs only supports Node.js version >= 18, this won't affect normal line-bot-sdk-nodejs users.ref: nodejs/node#36098, https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2021-09-28-version-14180-fermium-lts-targos
ref: https://nodejs.org/api/esm.html#node-imports
list: https://github.com/sindresorhus/builtin-modules/blob/main/builtin-modules.json