Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java-socks-proxy-server #1442

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

eucyt
Copy link
Contributor

@eucyt eucyt commented Oct 8, 2024

In java-socks-proxy-server v4.1.2, the return value of start() has been changed to null.
bbottema/java-socks-proxy-server@e1286c2#diff-b1e6e3096f697b3fa6365676e216d916a266831015b0593304abfb6b00adcd74R45

Therefore, we need to fix the tests and update their version manually.

Close #1435

@eucyt eucyt requested review from Yang-33, mokuzon and habara-k October 8, 2024 11:11
@eucyt eucyt self-assigned this Oct 8, 2024
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eucyt eucyt merged commit 74a2a88 into line:master Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants