Reload webpages when refreshed #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: After line#1013 is merged, I found out that a web page failed to reload when a refresh button is clicked or directly access to `/app/projects` It is caused by a bug of Armeria `FileService` which returns an empty file instead of a non-existent file when 1) the target path is a directory and the path does not end with `/`. The `FileService` has `.html` as a fallback extension. If `/app/projects` is requested, I expect `/app/projects.html` to be returned because `/app/projects` is directory. However, it only works with `FileSystemHttpVfs` but not `ClassPathHttpVfs`. ``` /app/projects/[projectName].html /app/projects.html ``` The problem wasn't caught by unit tests because `FileSystemHttpVfs` was always used. During the tests, The class loader directly loads by the test resouces from the file system. Modifications: - Always return `/webapp/index.html` for `/app/**` paths. - Next.js will load the correct page on the client side. Result: Fixed a regression where the webapp failed to render deep links.
jrhee17
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
After #1013 is merged, I found out that a web page failed to reload when a refresh button is clicked or directly access to
/app/projectsIt is caused by a bug of Armeria
FileServicewhich returns an empty file instead of a non-existent file when 1) the target path is a directory and 2) the path does not end with/.The
FileServicehas.htmlas a fallback extension. If/app/projectsis requested, I expect/app/projects.htmlto be returned because/app/projectsis directory. However, it only works withFileSystemHttpVfsbut notClassPathHttpVfs.The problem wasn't caught by unit tests because
FileSystemHttpVfswas always used instead. During the tests, the class loader directly loads the test resources from the file system.Modifications:
/webapp/index.htmlfor/app/**paths.Result:
Fixed a regression where the webapp failed to render deep links.