Add @Nullable to the parameter of equals(Object)
#2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `Object.equals(Object)` accepts `null`, but many of our `equals()` implementations do not have `@Nullable` annotation on their parameters. Modifications: - Add `@Nullable` to the parameter of `equals(Object)` Result: - Better `null`-related inference
trustin
force-pushed
the
equals_nullability
branch
from
02ef56c
to
c3e37bf
Compare
eugene70
pushed a commit
to eugene70/armeria
that referenced
this pull request
Oct 16, 2019
Motivation: `Object.equals(Object)` accepts `null`, but many of our `equals()` implementations do not have `@Nullable` annotation on their parameters. Modifications: - Add `@Nullable` to the parameter of `equals(Object)` Result: - Better `null`-related inference
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: `Object.equals(Object)` accepts `null`, but many of our `equals()` implementations do not have `@Nullable` annotation on their parameters. Modifications: - Add `@Nullable` to the parameter of `equals(Object)` Result: - Better `null`-related inference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Object.equals(Object)acceptsnull, but many of ourequals()implementations do not have
@Nullableannotation on their parameters.Modifications:
@Nullableto the parameter ofequals(Object)Result:
null-related inference