-
Notifications
You must be signed in to change notification settings - Fork 56
Feat/display user name in partition #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2c055e7
9a25d56
9698627
7036fe9
4034f5a
639fb25
df818be
02e6e40
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -467,7 +467,7 @@ function UsersTab({ partitionName }: { partitionName: string }) { | |
| <Table> | ||
| <TableHeader> | ||
| <TableRow> | ||
| <TableHead>User ID</TableHead> | ||
| <TableHead>User</TableHead> | ||
| <TableHead>Role</TableHead> | ||
| <TableHead>Added</TableHead> | ||
| {canManage && <TableHead>Actions</TableHead>} | ||
|
|
@@ -476,8 +476,10 @@ function UsersTab({ partitionName }: { partitionName: string }) { | |
| <TableBody> | ||
| {usersQuery.data.members.map((user) => ( | ||
| <TableRow key={user.user_id}> | ||
| <TableCell className="font-mono text-sm"> | ||
| {user.user_id} | ||
| <TableCell className="text-sm"> | ||
| {user.display_name || ( | ||
| <span className="font-mono text-muted-foreground">{user.user_id}</span> | ||
| )} | ||
| </TableCell> | ||
|
Comment on lines
+479
to
483
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Keep a stable identifier visible with display names. Lines 480-482 and 513 show only the display name when available. Display names are not guaranteed to be unique, so administrators may be unable to distinguish members or confirm which account will be removed. Keep Also applies to: 511-514 🤖 Prompt for AI Agents |
||
| <TableCell> | ||
| {canManage ? ( | ||
|
|
@@ -508,7 +510,7 @@ function UsersTab({ partitionName }: { partitionName: string }) { | |
| <TableCell> | ||
| <ConfirmDialog | ||
| title="Remove User" | ||
| description={`Remove user "${user.user_id}" from this partition? They will lose access to partition data.`} | ||
| description={`Remove user "${user.display_name || user.user_id}" from this partition? They will lose access to partition data.`} | ||
| onConfirm={() => removeMutation.mutate(user.user_id)} | ||
| > | ||
| <Button | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Performance & Scalability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: linagora/openrag
Length of output: 3527
🏁 Script executed:
Repository: linagora/openrag
Length of output: 4635
🏁 Script executed:
Repository: linagora/openrag
Length of output: 3415
Bound the membership user lookups.
asyncio.gather(...)launches one DB call per member, andUserRepositoryhas no batch fetch here. Large partitions can overwhelm the pool; chunk these lookups or add a bulk user query.🤖 Prompt for AI Agents