ci(build): build the admin-ui image on release tags - #648
Conversation
📝 WalkthroughWalkthroughAdds a new GitHub Actions job to build and push a Docker image for the admin UI on tag pushes to main, including registry logins, metadata extraction, and cached build/push steps using infra/docker/ui.Dockerfile. ChangesCI Admin UI Image Build
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/build.yml (1)
118-168: 🔒 Security & Privacy | 🔵 Trivial | 💤 Low valueJob structure and configuration look correct.
The new
build-and-push-image-admin-uijob correctly mirrors the existingbuild-and-push-imagejob: same trigger guard (base_ref == 'refs/heads/main'), same permissions, Docker Hub login (needed since it pushes tolinagoraai/openrag-admin-ui), correct Dockerfile (infra/docker/ui.Dockerfile), and matching image names/tags. The downstream Helm chart values (linagoraai/openrag-admin-ui) align with the image name here. The omission of the "Extract tag version" step is fine — it's unused in the existing jobs as well.One minor security note: the
actions/checkout@v4step doesn't setpersist-credentials: false, which means theGITHUB_TOKENpersists in the local git config for the job's duration. This is consistent with the other jobs in this file, so consider addressing it across all jobs in a follow-up rather than just this one.🔒 Optional: disable credential persistence
steps: - uses: actions/checkout@v4 + with: + persist-credentials: false🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/build.yml around lines 118 - 168, The `build-and-push-image-admin-ui` job’s `actions/checkout@v4` step should disable persisted git credentials to avoid leaving `GITHUB_TOKEN` in the local config. Update the checkout configuration in this job’s setup so it does not persist credentials, and apply the same change consistently to the other checkout steps in the workflow if you want a file-wide fix.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/build.yml:
- Around line 118-168: The `build-and-push-image-admin-ui` job’s
`actions/checkout@v4` step should disable persisted git credentials to avoid
leaving `GITHUB_TOKEN` in the local config. Update the checkout configuration in
this job’s setup so it does not persist credentials, and apply the same change
consistently to the other checkout steps in the workflow if you want a file-wide
fix.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6f4e1116-b30b-417c-8512-5b82e96fe6ae
📒 Files selected for processing (1)
.github/workflows/build.yml
What
Add the
admin-uibuild job to the GA release workflow (build.yml), mirroring the one already inbuild_rc.yml.Why
build.yml(runs onv*tags) built onlyopenrag(api) +openrag-ray. Theopenrag-admin-uiimage was produced only by the RC workflow, so a GA tag would publish the backend + ray images but no admin-ui — the UI container wouldImagePullBackOffat that version.Details
Same build recipe as
build_rc.yml's admin-ui job:infra/docker/ui.Dockerfile, context., pushes toghcr.io/linagora/openrag-admin-ui+linagoraai/openrag-admin-ui, samebase_ref == maintag guard andtype=ref,event=tag+latesttags. No build-args (matches the RC build exactly).Summary by CodeRabbit