docs(env): document 35 missing variables and fix stale defaults - #632
Conversation
Cross-checked every env var the code, compose stack and entrypoints actually read (config loader mappings, os.getenv call sites, compose interpolation, shell scripts) against the docs tree, and closed the gap: - Loaders: PARSE_TIMEOUT; new Docling section (DOCLING_POOL_SIZE, DOCLING_MAX_TASKS_PER_WORKER, DOCLING_NUM_GPUS); WHISPER_NUM_GPUS; TRANSCRIBER_PORT - Embedder: EMBEDDER_TIMEOUT, EMBEDDER_BATCH_SIZE, EMBEDDER_CONCURRENCY - Chat pipeline: MAX_OUTPUT_TOKENS; new RAG Pipeline Mode block (RAG_MODE) - Retriever: INCLUDE_RELATED, INCLUDE_ANCESTORS, RELATED_LIMIT, MAX_DEPTH, RETRIEVER_ALLOW_FILTERLESS_FALLBACK - Reranker: RERANKER_PORT - FastAPI: WITH_OPENAI_API, WITH_CHAINLIT_UI - Rate limiting: RATE_LIMIT_AUTH_FAILURE (with its fallback chain) - New Advanced & Legacy section: the six seed-time legacy aliases (LLM_ENDPOINT, LLM_MODEL, VLM_ENDPOINT, EMBEDDER_ENDPOINT, EMBEDDING_MODEL, RERANKER_ENDPOINT) as an alias->canonical table; operational vars (OPENRAG_CONF_DIR, DATA_DIR, DB_DIR, LOG_DIR, OPENRAG_CONTAINER_STARTUP_TIMEOUT, OPENRAG_BANNER, UVICORN_RELOAD); monitoring profile (GRAFANA_ADMIN_USER, GRAFANA_ADMIN_PASSWORD) - Note that the quick_start stack names the MinIO credentials MINIO_ROOT_USER/MINIO_ROOT_PASSWORD Accuracy fixes against conf/config.yaml: MAX_MODEL_LEN 8192->2047, MAP_REDUCE_DEBUG true->false, WITH_SURROUNDING_CHUNKS true->false. Also repaired the LLM/VLM tables whose 3-column header silently dropped the Default cell of their 4-cell rows.
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the environment-variable reference for OpenRAG v2.0.0, adding new settings for parsing, loaders, transcription, embeddings, retrieval, service mounts, rate limiting, and advanced/legacy behavior, while revising several documented defaults and notes. ChangesEnvironment Variable Documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/content/docs/documentation/env_vars.md`:
- Around line 265-290: Add blank lines around the rebuilt LLM and VLM
configuration tables in env_vars.md. Update the markdown around the table blocks
so there is an empty line before and after each table to satisfy markdownlint
MD058 and keep GFM/Astro parsing stable. Use the table sections under the LLM
Configuration and VLM Configuration headings as the locations to fix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 59a851fb-a291-4a77-91a3-256cc65ebb87
📒 Files selected for processing (1)
docs/content/docs/documentation/env_vars.md
The overview note still claimed the page tracked v1.1.2 and was an incomplete work in progress; after this PR the reference is exhaustive, so state the actual version, how defaults are verified, and where the auth/OIDC variables live instead.
What
Follow-up to #624: cross-checked every env var the code, compose stack and entrypoints actually read (config-loader mappings,
os.getenvcall sites, compose interpolation incl. extern includes, shell scripts) against the whole docs tree, and closed the remaining gap — 35 variables documented, plus a few stale defaults fixed.Added to
env_vars.mdPARSE_TIMEOUT; new Docling Loader Configuration subsection (DOCLING_POOL_SIZE,DOCLING_MAX_TASKS_PER_WORKER,DOCLING_NUM_GPUS);WHISPER_NUM_GPUS;TRANSCRIBER_PORTEMBEDDER_TIMEOUT,EMBEDDER_BATCH_SIZE,EMBEDDER_CONCURRENCYMAX_OUTPUT_TOKENS; new RAG Pipeline Mode block (RAG_MODE:ChatBotRagvsSimpleRag)INCLUDE_RELATED,INCLUDE_ANCESTORS,RELATED_LIMIT,MAX_DEPTH,RETRIEVER_ALLOW_FILTERLESS_FALLBACK(linked to the Linked-files page)RERANKER_PORTWITH_OPENAI_API,WITH_CHAINLIT_UIRATE_LIMIT_AUTH_FAILURE, with its fallback chain (RATE_LIMIT_AUTH→20/minute) — the one gap inside docs(env): slim .env.example to essentials and fill env-var doc gaps #624's own new sectionLLM_ENDPOINT,LLM_MODEL,VLM_ENDPOINT,EMBEDDER_ENDPOINT,EMBEDDING_MODEL,RERANKER_ENDPOINT) as a compact alias → canonical fallback table, marked "initial seeding only, prefer canonical"OPENRAG_CONF_DIR,DATA_DIR,DB_DIR,LOG_DIR,OPENRAG_CONTAINER_STARTUP_TIMEOUT,OPENRAG_BANNER,UVICORN_RELOADGRAFANA_ADMIN_USER,GRAFANA_ADMIN_PASSWORDinfra/quick_start/stack requires the credentials under different names (MINIO_ROOT_USER/MINIO_ROOT_PASSWORD)Accuracy fixes (doc default vs
conf/config.yaml)MAX_MODEL_LENMAP_REDUCE_DEBUGWITH_SURROUNDING_CHUNKSAlso repaired the LLM/VLM config tables: a 3-column header over 4-cell rows meant the Default cell of
LLM_SEMAPHORE/MAX_LLM_CONTEXT_SIZE(and VLM equivalents) was silently dropped at render.Verification
Re-ran the sweep after the change: every variable read by the app, compose stack and entrypoints is now either documented or intentionally excluded (script-local shell vars, Helm chart values,
extern/chainlit-datalayersubmodule dev tooling, OS conventions likeNO_COLOR/XDG_CACHE_HOME).Out of scope / follow-ups spotted
SEMAPHORE(core/config/loader.py) is currently inert: it fillssemaphore.*viasetdefault, butconf/config.yamlalways pre-populates both keys, so it never fires. Deliberately left undocumented; needs a code fix or removal.VDB_iPORT(core/config/loader.py) — mixed-case typo alias mapped right above the correctVDB_PORT; candidate for removal.Summary by CodeRabbit