Skip to content

fix(streaming): don't attach finish_reason to content-bearing chunk #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EnjoyBacon7 merged 1 commit into from
Jun 12, 2026
Merged

fix(streaming): don't attach finish_reason to content-bearing chunk #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openrag/components/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,10 @@ async def stream_with_source_filtering(
if chunk_template and len(final_clean) > emitted_len:
tail_chunk = copy.deepcopy(chunk_template)
tail_chunk["choices"][0]["delta"] = {"content": final_clean[emitted_len:]}
# Content chunk must not carry finish_reason (template may be the
# finish chunk); clients treat such a chunk as terminal and drop its
# delta. The separate finish chunk below emits it with an empty delta.
tail_chunk["choices"][0]["finish_reason"] = None
tail_chunk["extra"] = filtered_json
yield f"data: {json.dumps(tail_chunk)}\n\n"

Expand Down
Loading