Skip to content

fix: drop chat_template_kwargs for Mistral 3.2 compatibility #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ahmath-Gadji merged 1 commit into from
Apr 23, 2026
Merged

fix: drop chat_template_kwargs for Mistral 3.2 compatibility #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions benchmarks/prompt_eval/eval_query_decomposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ def build_llm_messages(prompt: str, messages: list[dict]) -> list[dict]:
def _model_kwargs(base_url: str) -> dict:
"""Return call-time kwargs; omit vLLM-specific extra_body for OpenAI endpoints."""
kwargs: dict = {"max_completion_tokens": 512}
if "openai.com" not in base_url:
kwargs["extra_body"] = {"chat_template_kwargs": {"enable_thinking": False}}
# if "openai.com" not in base_url:
# kwargs["extra_body"] = {"chat_template_kwargs": {"enable_thinking": False}}
return kwargs


Expand Down
4 changes: 2 additions & 2 deletions benchmarks/prompt_eval/eval_temporal_filter_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ def build_llm_messages(prompt: str, messages: list[dict]) -> list[dict]:
def _model_kwargs(base_url: str) -> dict:
"""Return call-time kwargs; omit vLLM-specific extra_body for OpenAI endpoints."""
kwargs: dict = {"max_completion_tokens": 512}
if "openai.com" not in base_url:
kwargs["extra_body"] = {"chat_template_kwargs": {"enable_thinking": False}}
# if "openai.com" not in base_url:
# kwargs["extra_body"] = {"chat_template_kwargs": {"enable_thinking": False}}
return kwargs


Expand Down
2 changes: 1 addition & 1 deletion openrag/components/indexer/loaders/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def __init__(self, **kwargs) -> None:
"temperature": 0.2,
"max_retries": 3,
"timeout": 60,
"extra_body": {"chat_template_kwargs": {"enable_thinking": False}},
# "extra_body": {"chat_template_kwargs": {"enable_thinking": False}},
}
settings.update(model_settings)

Expand Down
2 changes: 1 addition & 1 deletion openrag/components/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ async def generate_query(self, messages: list[dict]) -> SearchQueries:

model_kwargs = {
"max_completion_tokens": self.max_contextualized_query_len,
"extra_body": {"chat_template_kwargs": {"enable_thinking": False}},
# "extra_body": {"chat_template_kwargs": {"enable_thinking": False}},
}
prompt = QUERY_CONTEXTUALIZER_PROMPT.format(
query_language=query_language,
Expand Down
Loading