Skip to content

Fix: Not raising exception when the get_captions method fails #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ahmath-Gadji merged 1 commit into from
Jan 6, 2026
Merged

Fix: Not raising exception when the get_captions method fails #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions openrag/components/indexer/loaders/pdf_loaders/marker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,14 @@ async def _get_captions(self, img_dict: dict) -> dict:
try:
results = await tqdm.gather(*tasks, desc="Captioning images")
assert len(keys) == len(results), "Mismatch between keys and results count"
result_dict = dict(zip(keys, results))
return result_dict

except asyncio.CancelledError:
logger.warning("Image captioning tasks cancelled")
for task in tasks:
task.cancel()
raise
except Exception:
logger.exception("Error during image captioning")
raise
result_dict = dict(zip(keys, results))
return result_dict
except Exception as e:
logger.exception("Error during image captioning", error=str(e))
return {}