fix pptx bug - #119
Merged
Merged
Conversation
paultranvan
reviewed
Oct 22, 2025
| except ValueError as e: | ||
| # Handle the specific error for unsupported chart types | ||
| if "unsupported plot type" in str(e): | ||
| return "\n\n[unsupported chart]\n\n" |
Collaborator
There was a problem hiding this comment.
Since the handling of this exception is the same as the generic Exception, there is no point to have a specific ValueError exception, as I guess it inherits from Exception?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
PPTXLoaderby skipping unsupported shapes that are not yet implemented inpython-pptx.Fix HTML table conversion to Markdown.