Skip to content

Fix CI #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dodekapod merged 2 commits into from
Oct 21, 2025
Merged

Fix CI #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bfd488
An attempt to fix restore script
dodekapod Oct 20, 2025
5ea9569
Add argument "user-id" to restore script
dodekapod Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions openrag/scripts/restore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,6 @@
from pymilvus import MilvusClient
from utils.logger import get_logger

# It will create a the Milvus collection if it doesn't exist
vdb = MilvusDB.options(
name="Vectordb", namespace="openrag", lifetime="detached"
).remote()

ray.get(
vdb.__ray_ready__.remote()
) # ensure the actor is fully initialized and ready: collection and all created if nont existing
print("VectorDB (Milvus) actor fully initialized")


def read_rdb_section(
fh: IO[str],
Expand All @@ -29,6 +19,7 @@ def read_rdb_section(
added_documents: Dict[str, Set[str]],
existing_partitions: Dict[str, Any],
logger: Any,
user_id: int,
verbose: bool = False,
dry_run: bool = False,
) -> None:
Expand All @@ -42,6 +33,7 @@ def read_rdb_section(
added_documents: Dict mapping added partitions to sets of added file IDs.
existing_partitions: Dict of already existing partitions to avoid duplicates.
logger: Logger for status and error reporting.
user_id: User id to pass to PartitionFileManager
verbose: If True, logs additional info.
dry_run: If True, no changes are made to the database.
"""
Expand Down Expand Up @@ -81,7 +73,7 @@ def read_rdb_section(

if not dry_run:
try:
res = pfm.add_file_to_partition(doc["file_id"], part["name"], doc)
res = pfm.add_file_to_partition(doc["file_id"], part["name"], doc, user_id)
except Exception as e:
logger.exception(
f"{type(e)} in add_file_to_partition({doc['file_id']}, {part['name']}, ...)\n"
Expand Down Expand Up @@ -271,12 +263,34 @@ def load_openrag_config(logger: Any) -> Tuple[Dict[str, Any], Dict[str, Any]]:
action="store_true",
help="Don't change the target database",
)
parser.add_argument(
"-u",
"--user-id",
default=1,
help="Create partitions with this user-id"
)
parser.add_argument("input", help="input file name")

args = parser.parse_args()

logger = get_logger()


try:
# It will create a the Milvus collection if it doesn't exist
vdb_tmp = MilvusDB.options(
name="Vectordb", namespace="openrag", lifetime="detached"
).remote()

ray.get(
vdb_tmp.__ray_ready__.remote()
) # ensure the actor is fully initialized and ready: collection and all created if nont existing
print("VectorDB (Milvus) actor fully initialized")
except Exception as e:
logger.exception(f'Failed while trying to create Milvus collection: {e}')
# TODO: stop execution here


rdb, vdb = load_openrag_config(logger)

if args.verbose:
Expand Down Expand Up @@ -323,6 +337,7 @@ def load_openrag_config(logger: Any) -> Tuple[Dict[str, Any], Dict[str, Any]]:
added_documents,
existing_partitions,
logger,
args.user_id,
args.verbose,
args.dry_run,
)
Expand Down