Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-625: unit test #27

Merged
merged 1 commit into from
Jun 13, 2022
Merged

TF-625: unit test #27

merged 1 commit into from
Jun 13, 2022

Conversation

ManhNTX
Copy link
Contributor

@ManhNTX ManhNTX commented Jun 13, 2022 •
edited
Loading

Create unit test for search use case. @hoangdat @dab246 Please check it

@hoangdat
Copy link
Member

Please more detail on commit's message

@hoangdat
Copy link
Member

hoangdat commented Jun 13, 2022 •
edited
Loading

build failed

00:23 +33 -3: /home/runner/work/jmap-dart-client/jmap-dart-client/test/jmap/email/search/use_case_test/search_emails_inbox_use_case_test.dart: search email test Search emails in Inbox which have the string report [E]

  DioError [DioErrorType.other]: Assertion failed: "Could not find mocked route matching request for POST /jmap { data: {methodCalls: [[Email/query, {accountId: 0eacc7a5c74b27ab36a823bc5c34da36e16c093705f241d6ed5f48ee73a4ecfb, filter: {inMailbox: c2543650-32cf-11eb-995c-a3ae66e9f96a, text: report}, limit: 3}, c2], [Email/get, {accountId: 0eacc7a5c74b27ab36a823bc5c34da36e16c093705f241d6ed5f48ee73a4ecfb, #ids: {resultOf: c2, name: Email/query, path: ids/*}, properties: [id, subject, size, from, receivedAt, sentAt, preview, hasAttachment]}, c3]], using: [urn:ietf:params:jmap:core, urn:ietf:params:jmap:mail]}, query parameters: {}, headers: {accept: application/json;jmapVersion=rfc-8621, content-type: application/json; charset=utf-8, content-length: 526} }"

@ManhNTX ManhNTX requested review from dab246 and hoangdat June 13, 2022 09:08
dab246
dab246 reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, You should write some failed cases for search.

test/jmap/email/search/use_case_test/search_by_form_use_case_test.dart Outdated Show resolved Hide resolved
test/jmap/email/search/use_case_test/search_by_after_use_case_test.dart Outdated Show resolved Hide resolved
test/jmap/email/search/use_case_test/search_by_form_use_case_test.dart Outdated Show resolved Hide resolved
@ManhNTX ManhNTX force-pushed the feature/TF-625_unit_test branch 3 times, most recently from 772d7f5 to df1b89a Compare June 13, 2022 11:12
@ManhNTX ManhNTX force-pushed the feature/TF-625_unit_test branch from df1b89a to 2514199 Compare June 13, 2022 11:14
@hoangdat hoangdat merged commit 68facac into linagora:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dab246 dab246 dab246 approved these changes

@hoangdat hoangdat hoangdat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManhNTX @hoangdat @dab246