Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of Close (x) buttons are not consistent #2031

Closed
Tracked by #2026
hantt12 opened this issue Mar 29, 2022 · 0 comments
Closed
Tracked by #2026

Position of Close (x) buttons are not consistent #2031

hantt12 opened this issue Mar 29, 2022 · 0 comments
Assignees

Comments

@hantt12
Copy link

hantt12 commented Mar 29, 2022

For some dialog, close button in on the right top but for others, it's on the left top
Please make it consistent

image.png

image.png

@hantt12 hantt12 added bug Something isn't working Minor 🎨 ui-ux labels Mar 29, 2022
@RomaricMourgues RomaricMourgues self-assigned this Mar 30, 2022
RomaricMourgues added a commit to RomaricMourgues/Twake that referenced this issue Mar 30, 2022
RomaricMourgues added a commit to RomaricMourgues/Twake that referenced this issue Mar 30, 2022
RomaricMourgues added a commit that referenced this issue Mar 31, 2022
* Start cleanup

* Fix width for not large pictures

* Improve preview generation, jwt cleaning, apps command

* Make channels menus async loaded to have faster channels

* Fixing state management bugs

* FIx openDiscussion

* Fix direct channels list not everywhere

* Remove channels.js deprecated service

* Put back auto select channel

* Fix preview file before send + load bar

* Add ascii folding

* Update pinned view API and add flat option

* Update dockers

* Fix the dockers

* Fix package.json and backend build

* Fix docker

* Add logs

* Fix mongo search test

* FIx typo in elasticsearch

* Add logs for ES

* Try to show the log

* Fix #2031

* Fix #2031

* Fix direct chat not reordered automatically

* Fix "Bar" channel is empty and won't load

* Show the logs in es tests

* Fix to locale lower case

* Remove useless logs

* Make sure users are deleted from where they should be deleted

* Update comment + rm console.log
RomaricMourgues added a commit that referenced this issue Mar 31, 2022
* Start cleanup

* Fix width for not large pictures

* Improve preview generation, jwt cleaning, apps command

* Make channels menus async loaded to have faster channels

* Fixing state management bugs

* FIx openDiscussion

* Fix direct channels list not everywhere

* Remove channels.js deprecated service

* Put back auto select channel

* Fix preview file before send + load bar

* Add ascii folding

* Update pinned view API and add flat option

* Update dockers

* Fix the dockers

* Fix package.json and backend build

* Fix docker

* Add logs

* Fix mongo search test

* FIx typo in elasticsearch

* Add logs for ES

* Try to show the log

* Fix #2031

* Fix #2031

* Fix direct chat not reordered automatically

* Fix "Bar" channel is empty and won't load

* Show the logs in es tests

* Fix to locale lower case

* Remove useless logs

* Make sure users are deleted from where they should be deleted

* Update comment + rm console.log
RomaricMourgues added a commit that referenced this issue Mar 31, 2022
* Start cleanup

* Fix width for not large pictures

* Improve preview generation, jwt cleaning, apps command

* Make channels menus async loaded to have faster channels

* Fixing state management bugs

* FIx openDiscussion

* Fix direct channels list not everywhere

* Remove channels.js deprecated service

* Put back auto select channel

* Fix preview file before send + load bar

* Add ascii folding

* Update pinned view API and add flat option

* Update dockers

* Fix the dockers

* Fix package.json and backend build

* Fix docker

* Add logs

* Fix mongo search test

* FIx typo in elasticsearch

* Add logs for ES

* Try to show the log

* Fix #2031

* Fix #2031

* Fix direct chat not reordered automatically

* Fix "Bar" channel is empty and won't load

* Show the logs in es tests

* Fix to locale lower case

* Remove useless logs

* Make sure users are deleted from where they should be deleted

* Update comment + rm console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants