add (return) type hints to overriden methods #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony logs deprecations for overriden methods when the signature doesn't match that of the parent (based on both actual typehints or PHPDoc). So this fixes these deprecations. This also makes the code "forward" compatible for when the base class (/package) does actually add these typehints.
|
@arietimmerman could you please have a look at this? 😄 This is about the only thing which is still giving me deprecation messages using Symfony. |
|
Looks good. Thanks |
karlatascent
added a commit
to Ascent-Software-Group/openid-connect-server
that referenced
this pull request
Jan 3, 2024
* Provide a default empty string value for nonce (limosa-io#11) Recent PHP versions emit an error on the subsequent call to strlen() if the nonce value is null. * ImplicitGrant forgot to fill scopes (limosa-io#12) * Emit event when id token is populated (limosa-io#16) * Replace bogus identifier with configuration option (limosa-io#17) * Replace bogus identifier with configuration option * Fix emitting TOKEN_POPULATED event from AuthCodeGrant * Fix unit tests (limosa-io#18) * Fix failure after limosa-io#17 * Fix some PHP 8 deprecations because of missing values * Use the Session service for the implicit grant (limosa-io#19) * Enable CI workflow for pull requests (limosa-io#20) Should prevent merging PRs with failing unit tests :) * Improve ResponseHandler (limosa-io#24) * Don't continue checking handler when one (/first) matches * Fix "Undefined variable $response" error when no handler matched * Harden AuthCodeGrant::canRespondToAccessTokenRequest (limosa-io#25) * Skip (additional) checks when grant_type isn't even authorization_code * Simplify check whether code request parameter is present * Handle exception when code can't be decrypted (for example when sending empty value, or any value which isn't properly encrypted) * Add check whether decoded token contains scopes (to prevent undefined variable error when it isn't) * Store claims for implicit flow (limosa-io#23) * Feat update packages (limosa-io#28) Upgraded dependencies lcobucci/jwt and league/oauth2-server * Formatting and warning fixes (limosa-io#29) * documentation update (limosa-io#30) * add (return) type hints to overriden methods (limosa-io#26) --------- Co-authored-by: flh <[email protected]> Co-authored-by: Robert Meijers <[email protected]> Co-authored-by: Robert Meijers <[email protected]> Co-authored-by: Oluwatobi Samuel Omisakin <[email protected]> Co-authored-by: Arie Timmerman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony logs deprecations for overriden methods when the signature doesn't match that of the parent (based on both actual typehints or PHPDoc). So this fixes these deprecations. This also makes the code "forward" compatible for when the base class (/package) does actually add these typehints.