fix a lot of memory leaks

[halturin]

No description provided.

[coveralls]

Coverage decreased (-0.3%) to 22.23% when pulling 6cbe5a9 on halturin:master into bd3afdc on limetext:master.

[coveralls]

Coverage decreased (-0.3%) to 22.23% when pulling 6cbe5a9 on halturin:master into bd3afdc on limetext:master.

[zoli]

I don't get why are you removing this? and similar ones.

[halturin]

it causes memory leaks. there is no code which in charge to remove an item from the map

[zoli]

But doesn't this enable us to reuse an object created before and not create it again?

[halturin]

I think its broken by design, i mean the way to save few bytes and couple milliseconds :) and caused a lot of memory leaks with random data. There are two ways to fix it:

1. remove the reason (pull request)
2. implement some kind of TTL (time to live) for every single item stored this way

its your repo, your choice :)

Anyway, i've forked this repo and using it without leaks

[zoli]

Ok, so I will check if there is any problem with other repositories while using these changes. Thanks

[zoli]

I have checked this. Although the tests are passing but with https://github.com/limetext/sublime, It's causing panic:

unexpected fault address 0x7f40647ddba8
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x2 addr=0x7f40647ddba8 pc=0x7d4719]

[zoli]

Reopenning this because the error mentioned is not related to this pr. We should test this after resolving #16.

[coveralls]

Coverage decreased (-0.2%) to 22.278% when pulling 6cbe5a9 on halturin:master into bd3afdc on limetext:master.

[coveralls]

Coverage decreased (-0.2%) to 22.278% when pulling 6cbe5a9 on halturin:master into bd3afdc on limetext:master.

[zoli]

This should get applied after resolving #12 (comment).