Underneath mode: Remove the old highlight before switching textView. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure the old one doesn't remain there.
limejelly
pushed a commit
that referenced
this pull request
Mar 30, 2015
Underneath mode: Remove the old highlight before switching textView.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure the old one doesn't remain there.
In the previous fix of #27 , I tried to observe the NSTextDidEndEditingNotification to check if the old highlight should be removed. But obviously it's not enough: #35
So perform the removing the old highlight by the timing of switching textView. The current action should be the same as Overlay mode.