Fix #27 #31
Merged
Fix #27 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the highlighted line when editor lost focus. The behaviour is the same as Overlay mode.
What caused the issue
When using Underneath mode, the current line is highlighted by the current editor's layout manager. The editor is not aware when the focus changed to somewhere else, so the highlighted line remains there.
Why not happen in Overlay mode
In Overlay mode, when focus changed to another editor, the NSWindowDidBecomeKeyNotification will fire in the new editor. Then in
moveBacklightInTextView:method,[self.currentBacklightView removeFromSuperview];will execute and the old highlighted line will be removed.