Fix reparenting an agent deactivates its HSM #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limbonaut
force-pushed
the
fix-reparenting-issue
branch
from
8ac252e to
06de524
Compare
limbonaut
added a commit
that referenced
this pull request
Sep 22, 2024
Since #131, `LimboState::_exit()` became a source of potential crashes if object references are used without a validity check. It's too easy to miss this, which can lead to game crashing during runtime. This fix reverts #131 change and proposes alternative approach of re-activating root HSM upon tree entering if it was previously active. Note that it's not an ideal solution, as some state will be lost upon re-parenting: HSM exits and then re-activates and enters its initial state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #128