`nvmm` is tested and works fine #914

iamleot · 2022-06-19T13:26:05Z

At least on NetBSD/amd64 -current(-ish) it works well.

Signed-off-by: Leonardo Taccari <[email protected]>

afbjorklund · 2022-06-19T16:13:49Z

But -cpu host failed, right ? Did -cpu max work, btw ?

Not all OS with -accel has -cpu host option #900

afbjorklund · 2022-06-19T16:17:39Z

@iamleot do the unit tests pass, on netbsd ?

go test ./...

iamleot · 2022-06-19T16:18:37Z

But -cpu host failed, right ? Did -cpu max work, btw ?

Not all OS with -accel has -cpu host option #900

Yes, -cpu max works.

iamleot · 2022-06-19T16:24:37Z

@iamleot do the unit tests pass, on netbsd ?
go test ./...

If I try on a clean checked out source it fails with:

$ go test -v ./...
go: github.com/containerd/[email protected] requires
        github.com/AdaLogics/[email protected]: missing go.sum entry; to add it:
        go mod download github.com/AdaLogics/go-fuzz-headers

I guess I'm missing something obvious, right? :)

iamleot · 2022-06-19T16:28:14Z

I have done a go mod download github.com/AdaLogics/go-fuzz-headers and after that:

$ go test ./...
# github.com/lima-vm/lima/pkg/cidata
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/cidata [setup failed]
# github.com/lima-vm/lima/pkg/downloader
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/downloader [setup failed]
# github.com/lima-vm/lima/pkg/guestagent/procnettcp
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/guestagent/procnettcp [setup failed]
# github.com/lima-vm/lima/pkg/hostagent/dns
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/hostagent/dns [setup failed]
# github.com/lima-vm/lima/pkg/limayaml
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/limayaml [setup failed]
# github.com/lima-vm/lima/pkg/networks
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/networks [setup failed]
# github.com/lima-vm/lima/pkg/osutil
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/osutil [setup failed]
# github.com/lima-vm/lima/pkg/qemu
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/qemu [setup failed]
# github.com/lima-vm/lima/pkg/sshutil
pkg/cidata/template_test.go:8:2: missing go.sum entry needed to verify package gotest.tools/v3/assert (imported by github.com/lima-vm/lima/pkg/cidata) is provided by exactly one module; to add:
        go get -t github.com/lima-vm/lima/pkg/cidata
FAIL    github.com/lima-vm/lima/pkg/sshutil [setup failed]
?       github.com/lima-vm/lima/cmd/limactl     [no test files]
?       github.com/lima-vm/lima/pkg/guestagent  [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api      [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api/client       [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api/server       [no test files]
ok      github.com/lima-vm/lima/pkg/guestagent/iptables (cached)
?       github.com/lima-vm/lima/pkg/hostagent   [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api       [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api/client        [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api/server        [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/events    [no test files]
?       github.com/lima-vm/lima/pkg/httpclientutil      [no test files]
?       github.com/lima-vm/lima/pkg/httputil    [no test files]
?       github.com/lima-vm/lima/pkg/iso9660util [no test files]
?       github.com/lima-vm/lima/pkg/localpathutil       [no test files]
?       github.com/lima-vm/lima/pkg/lockutil    [no test files]
?       github.com/lima-vm/lima/pkg/logrusutil  [no test files]
?       github.com/lima-vm/lima/pkg/networks/reconcile  [no test files]
?       github.com/lima-vm/lima/pkg/qemu/const  [no test files]
?       github.com/lima-vm/lima/pkg/qemu/imgutil        [no test files]
?       github.com/lima-vm/lima/pkg/start       [no test files]
?       github.com/lima-vm/lima/pkg/store       [no test files]
?       github.com/lima-vm/lima/pkg/store/dirnames      [no test files]
?       github.com/lima-vm/lima/pkg/store/filenames     [no test files]
?       github.com/lima-vm/lima/pkg/templateutil        [no test files]
?       github.com/lima-vm/lima/pkg/usrlocalsharelima   [no test files]
?       github.com/lima-vm/lima/pkg/version     [no test files]
FAIL

iamleot · 2022-06-19T16:29:53Z

After doing a go get -t github.com/lima-vm/lima/pkg/cidata:

$ go test ./...
?       github.com/lima-vm/lima/cmd/limactl     [no test files]
ok      github.com/lima-vm/lima/pkg/cidata      0.012s
ok      github.com/lima-vm/lima/pkg/downloader  0.751s
?       github.com/lima-vm/lima/pkg/guestagent  [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api      [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api/client       [no test files]
?       github.com/lima-vm/lima/pkg/guestagent/api/server       [no test files]
ok      github.com/lima-vm/lima/pkg/guestagent/iptables (cached)
ok      github.com/lima-vm/lima/pkg/guestagent/procnettcp       0.004s
?       github.com/lima-vm/lima/pkg/hostagent   [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api       [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api/client        [no test files]
?       github.com/lima-vm/lima/pkg/hostagent/api/server        [no test files]
ok      github.com/lima-vm/lima/pkg/hostagent/dns       0.006s
?       github.com/lima-vm/lima/pkg/hostagent/events    [no test files]
?       github.com/lima-vm/lima/pkg/httpclientutil      [no test files]
?       github.com/lima-vm/lima/pkg/httputil    [no test files]
?       github.com/lima-vm/lima/pkg/iso9660util [no test files]
ok      github.com/lima-vm/lima/pkg/limayaml    0.010s
?       github.com/lima-vm/lima/pkg/localpathutil       [no test files]
?       github.com/lima-vm/lima/pkg/lockutil    [no test files]
?       github.com/lima-vm/lima/pkg/logrusutil  [no test files]
--- FAIL: TestUser (0.00s)
    commands_test.go:72: assertion failed: wheel (user.Group string) != root (string)
FAIL
FAIL    github.com/lima-vm/lima/pkg/networks    0.008s
?       github.com/lima-vm/lima/pkg/networks/reconcile  [no test files]
ok      github.com/lima-vm/lima/pkg/osutil      0.003s
ok      github.com/lima-vm/lima/pkg/qemu        0.004s
?       github.com/lima-vm/lima/pkg/qemu/const  [no test files]
?       github.com/lima-vm/lima/pkg/qemu/imgutil        [no test files]
ok      github.com/lima-vm/lima/pkg/sshutil     0.006s
?       github.com/lima-vm/lima/pkg/start       [no test files]
?       github.com/lima-vm/lima/pkg/store       [no test files]
?       github.com/lima-vm/lima/pkg/store/dirnames      [no test files]
?       github.com/lima-vm/lima/pkg/store/filenames     [no test files]
?       github.com/lima-vm/lima/pkg/templateutil        [no test files]
?       github.com/lima-vm/lima/pkg/usrlocalsharelima   [no test files]
?       github.com/lima-vm/lima/pkg/version     [no test files]
FAIL

afbjorklund · 2022-06-19T16:31:10Z

Thanks for checking, I guess the "wheel" is easy to fix (same as darwin)

        if runtime.GOOS == "darwin" {
                assert.Equal(t, user.Group, "wheel")
        } else {
                assert.Equal(t, user.Group, "root")
        }

Most likely, also FreeBSD.

iamleot · 2022-06-19T16:33:19Z

Thanks for checking, I guess the "wheel" is easy to fix (same as darwin)

        if runtime.GOOS == "darwin" {
                assert.Equal(t, user.Group, "wheel")
        } else {
                assert.Equal(t, user.Group, "root")
        }

Most likely, also FreeBSD.

Yeah, I will provide a patch about that in a separate PR (and I can confirm that it fixes all the tests then).

AkihiroSuda

Thanks

nvmm is tested and works fine

a25737d

Signed-off-by: Leonardo Taccari <[email protected]>

AkihiroSuda added the platform/NetBSD label Jun 20, 2022

AkihiroSuda approved these changes Jun 20, 2022

View reviewed changes

AkihiroSuda merged commit 30c5594 into lima-vm:master Jun 20, 2022

AkihiroSuda added this to the vNext milestone Jul 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`nvmm` is tested and works fine #914

`nvmm` is tested and works fine #914

iamleot commented Jun 19, 2022

afbjorklund commented Jun 19, 2022 •

edited

Loading

afbjorklund commented Jun 19, 2022 •

edited

Loading

iamleot commented Jun 19, 2022

iamleot commented Jun 19, 2022 •

edited

Loading

iamleot commented Jun 19, 2022

iamleot commented Jun 19, 2022

afbjorklund commented Jun 19, 2022 •

edited

Loading

iamleot commented Jun 19, 2022

AkihiroSuda left a comment

nvmm is tested and works fine #914

nvmm is tested and works fine #914

Conversation

iamleot commented Jun 19, 2022

afbjorklund commented Jun 19, 2022 • edited Loading

afbjorklund commented Jun 19, 2022 • edited Loading

iamleot commented Jun 19, 2022

iamleot commented Jun 19, 2022 • edited Loading

iamleot commented Jun 19, 2022

iamleot commented Jun 19, 2022

afbjorklund commented Jun 19, 2022 • edited Loading

iamleot commented Jun 19, 2022

AkihiroSuda left a comment

Choose a reason for hiding this comment

`nvmm` is tested and works fine #914

`nvmm` is tested and works fine #914

afbjorklund commented Jun 19, 2022 •

edited

Loading

afbjorklund commented Jun 19, 2022 •

edited

Loading

iamleot commented Jun 19, 2022 •

edited

Loading

afbjorklund commented Jun 19, 2022 •

edited

Loading