Fallbacks to -cpu max on native arch platforms that have an accelerator but do not support -cpu host
#913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On platforms that have an accelerator but `-cpu host' is not available fallback to `-cpu max' that enables all features supported by the accelerator in the current host. Signed-off-by: Leonardo Taccari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms that have an accelerator but
-cpu hostis not available fallbacks to-cpu maxthat enables all features supported by the accelerator in the current host.This was noticed on NetBSD. What actually happened is that in
qemu.Cmdline()if nothing adjust the CPU we will ends up with:lima/pkg/qemu/qemu.go
Line 372 in 6410674
where
-accelis currently hardcoded totcglater in:lima/pkg/qemu/qemu.go
Line 379 in 6410674
And so no host accelerator is used in such case.