Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always expand inst.Message field in store.Inspect #903

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

jandubois
Copy link
Member

There is no reason to let the user deal with template expansion when we can do this automatically after loading. This is especially useful in limactl list output:

$ limactl ls -f '{{.Message}}' docker
To run `docker` on the host (assumes docker-cli is installed), run the following commands:
------
docker context create lima --docker "host=unix:///Users/jan/.lima/docker/sock/docker.sock"
docker context use lima
docker run hello-world
------

See also #838 (comment)

There is no reason to let the user deal with template expansion when
we can do this automatically after loading. This is especially useful
in `limactl list` output.

Signed-off-by: Jan Dubois <[email protected]>
@jandubois jandubois added this to the v0.11.1 milestone Jun 15, 2022
@jandubois jandubois requested a review from AkihiroSuda June 15, 2022 21:55
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 5f435ce into lima-vm:master Jun 15, 2022
@jandubois jandubois deleted the expand-message branch June 15, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants