Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nerdctl: update to v0.18.0; configure BuildKit with containerd worker #756

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Mar 25, 2022

BuildKit daemon is now configured to use containerd worker, not OCI worker for efficiency and for supporting using local base images

https://github.com/containerd/nerdctl/blob/v0.18.0/docs/build.md#setting-up-buildkit-with-containerd-worker

@AkihiroSuda
Copy link
Member Author

@ktock PTAL

@AkihiroSuda AkihiroSuda added this to the v0.9.2 milestone Mar 25, 2022
@ktock
Copy link

ktock commented Mar 25, 2022

LGTM

@ktock
Copy link

ktock commented Mar 25, 2022

Maybe we should add the following example to the integration test.

https://github.com/containerd/nerdctl/blob/v0.18.0-beta.0/docs/build.md

$ mkdir -p /tmp/ctx && cat <<EOF > /tmp/ctx/Dockerfile
FROM ghcr.io/stargz-containers/ubuntu:20.04-org
RUN echo hello
EOF
$ nerdctl build -t foo /tmp/ctx
$ cat <<EOF > /tmp/ctx/Dockerfile
FROM foo
RUN echo bar
EOF
$ nerdctl build -t bar /tmp/ctx

@AkihiroSuda
Copy link
Member Author

Maybe we should add the following example to the integration test.

https://github.com/containerd/nerdctl/blob/v0.18.0-beta.0/docs/build.md

$ mkdir -p /tmp/ctx && cat <<EOF > /tmp/ctx/Dockerfile
FROM ghcr.io/stargz-containers/ubuntu:20.04-org
RUN echo hello
EOF
$ nerdctl build -t foo /tmp/ctx
$ cat <<EOF > /tmp/ctx/Dockerfile
FROM foo
RUN echo bar
EOF
$ nerdctl build -t bar /tmp/ctx

That should be probably in the nerdctl repo

@ktock
Copy link

ktock commented Mar 25, 2022

That should be probably in the nerdctl repo

👍

We already have it in nerdctl repo https://github.com/containerd/nerdctl/blob/10aae5ab75dc8a3156a7853e6cf5da624463bdb9/cmd/nerdctl/build_test.go#L51-L87

@AkihiroSuda AkihiroSuda changed the title [WIP] nerdctl: update to v0.18.0; configure BuildKit with containerd worker nerdctl: update to v0.18.0; configure BuildKit with containerd worker Mar 25, 2022
@AkihiroSuda AkihiroSuda marked this pull request as ready for review March 25, 2022 17:04
@AkihiroSuda AkihiroSuda merged commit e021ce7 into lima-vm:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants