Make cpuType a map instead of a single value #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
cputype-list
branch
from
7cc1ad0 to
254f68e
Compare
AkihiroSuda
reviewed
Feb 17, 2022
AkihiroSuda
reviewed
Feb 17, 2022
jandubois
force-pushed
the
cputype-list
branch
from
254f68e to
16377d5
Compare
That way a template lima.yaml can specify alternate cpu types for multiple archs. Also makes it possible to specify defaults and overrides for cpu type globally. Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
cputype-list
branch
from
16377d5 to
4c9b713
Compare
AkihiroSuda
reviewed
Feb 17, 2022
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way a template lima.yaml can specify alternate cpu types for multiple archs. Also makes it possible to specify defaults and overrides for cpu type globally.
Fixes #647