Implement unix socket forwarding #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
socket-forward-take2
branch
2 times, most recently
from
324ce9d to
2dcefdf
Compare
jandubois
changed the title
AkihiroSuda
reviewed
Oct 29, 2021
jandubois
force-pushed
the
socket-forward-take2
branch
4 times, most recently
from
3369df0 to
cddcaa2
Compare
AkihiroSuda
reviewed
Nov 2, 2021
jandubois
commented
Nov 2, 2021
Either or both sides of a forward can be a unix socket, but the user will need to have access to the socket because forwarding is done via ssh using user priviledges and not root. Signed-off-by: Jan Dubois <[email protected]>
Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
socket-forward-take2
branch
2 times, most recently
from
961a568 to
a8140f7
Compare
Signed-off-by: Jan Dubois <[email protected]>
* cancel HA context to stop reconnecting to the guestagent * don't show an error when ga connection is lost due to cancel * cancel ssh forwarding using Background() context to make sure it runs Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
socket-forward-take2
branch
from
a8140f7 to
dae7e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #367. It doesn't parse
/proc/net/unixat all, but just sets up any configured socket forwards when the guestagent is started, and tears them down when the hostagent exits.This is now my preferred implementation.
Fixes #221