Create amazonlinux2023 template #2537

siennathesane · 2024-08-07T21:03:54Z

Adds a default template reference for Amazon Linux 2023.

jandubois · 2024-08-07T22:24:42Z

Please fix lint error (remove trailing spaces on first line) and apply DCO signature to the commit: https://github.com/lima-vm/lima/pull/2537/checks?check_run_id=28484568245

examples/amazonlinux2023.yaml

AkihiroSuda · 2024-08-07T22:33:37Z

examples/amazonlinux2023.yaml

The filename should be amazonlinux.yaml

I disagree because Amazon Linux, Amazon Linux 2, and Amazon Linux 2023 are different operating systems in the same way that Fedora & RedHat are different operating systems. Given #625 was denied, it's an important distinction.

I still don't get why the new distro (and later versions) can't be called "amazonlinux".

Does that mean that the new distro will be called "Amazon Linux 2023" practically forever, even in 2030s?

No, there will be "Amazon Linux 2025", "Amazon Linux 2027", etc in the future.

You can see the expected lifecycles at https://docs.aws.amazon.com/linux/al2023/ug/release-cadence.html

No, there will be "Amazon Linux 2025", "Amazon Linux 2027", etc in the future.

So given that in 2027 there will be AL2023 and AL2025 in maintenance, and AL2027 will be the current version, I think it makes sense to include the "2023" in the name.

I wonder though if it should be amazonlinux-2023.yaml, and then have an amazonlinux.yaml symlink to it, similarly to how we have almalinux-9.yaml or debian-12.yaml. That way in the future we can symlink to amazonlinux-2025.yaml while still keeping the old amazonlinux-2023.yaml around until it is EOL.

I don't think it has to go in experimental either, just because upstream is missing a symlink?

I put it in experimental due to no latest version and because it requires virtiofs. Since virtiofs requires experimental vz on macOS, it made more sense. Do you want me to move it?

Does it require virtiofs, or does it just not support 9p? I was thinking it would fall back to reverse-sshfs?

Amazon Linux 2023 repository 13 MB/s | 26 MB 00:02 Amazon Linux 2023 Kernel Livepatch repository 2.2 kB/s | 8.3 kB 00:03 No match for argument: fuse-sshfs Error: Unable to find a match: fuse-sshfs

[Package Request] - FUSE-SSHFS amazonlinux/amazon-linux-2023#531

Also, # CONFIG_NET_9P is not set in kernel. So that means that it does indeed only support virtiofs.

AkihiroSuda · 2024-08-07T22:34:56Z

examples/amazonlinux2023.yaml

+vmType: "vz"
+mountType: "virtiofs"
+images:
+- location: "https://cdn.amazonlinux.com/al2023/os-images/2023.5.20240805.0/kvm/al2023-kvm-2023.5.20240805.0-kernel-6.1-x86_64.xfs.gpt.qcow2"


Are these images persistent for years, or are they wiped periodically?
In the latter case, the "latest" image has to be specified as a fallback option.
(See other templates)

Are these images persistent for years, or are they wiped periodically?

I don't know, that's an Amazon question, sorry. To my knowledge there is no latest option.

Are these images persistent for years, or are they wiped periodically?

I think "somebody" will have to reach out to AWS to find out. I'll be offline soon, so I can't do it right now; ping me in September if it is still unresolved by then. 😄

Maybe ask the finch people to find out who can help. They have a channel on the CNCF Slack.

It could be left to just go 404 when it is removed, like with the other distributions?

The "latest" is a nice to have / recovery, but ultimately they all need bumping anyway.

So is this image link fine for the purposes of the PR? It is an example of an experimental config, not a production config

afbjorklund · 2024-08-08T09:29:01Z

There is a https://cdn.amazonlinux.com/al2023/os-images/latest/ link, but all filenames seem to be unique?

https://docs.aws.amazon.com/linux/al2023/ug/outside-ec2-download.html

Maybe there could be an issue or documentation created upstream, how to link to the latest KVM image?

https://aws.amazon.com/about-aws/whats-new/2023/12/amazon-linux-kvm-vmware-images-al2023-3/

Maybe finch wants to help out, as well ?

Or I suppose you could just use fedora :-)

siennathesane · 2024-08-08T19:19:11Z

There is a https://cdn.amazonlinux.com/al2023/os-images/latest/ link, but all filenames seem to be unique?

https://docs.aws.amazon.com/linux/al2023/ug/outside-ec2-download.html

Maybe there could be an issue or documentation created upstream, how to link to the latest KVM image?

https://aws.amazon.com/about-aws/whats-new/2023/12/amazon-linux-kvm-vmware-images-al2023-3/

Do you want a link to that in the example file? I think anything more than that is more than I want to do for the scope of this PR.

Maybe finch wants to help out, as well ?

The two are different projects, I'm not sure how they relate, sorry.

Or I suppose you could just use fedora :-)

Amazon Linux 2023 & Fedora are not the same despite many similarities.

siennathesane · 2024-08-08T19:35:31Z

I moved it into experimental to allow for more user awareness of the state due to lack of latest support.

afbjorklund · 2024-08-09T06:09:37Z

I was just referring to that Amazon projects (like linux or finch) could make this easier for lima?

The template itself doesn't need that information (at the moment), beyond the "latest" image.

examples/experimental/amazonlinux2023.yaml

pendo324 · 2024-08-09T20:22:40Z

Maybe there could be an issue or documentation created upstream, how to link to the latest KVM image?

Unfortunately, I think this is the best we've got right now:

# extract the latest release from the repo
# append .0 to it so that it works properly in the CDN URL
# I'm not sure if this always has to be .0 or if it can be other digits
distribution_release_al2023="$(curl -s https://al2023-repos-us-west-2-de612dc2.s3.dualstack.us-west-2.amazonaws.com/core/releasemd.xml | xmllint --xpath "string(//root/releases/release[last()]/@version)" -).0"

# extract the filename from the SHASUMS file since that file name is "static"
filename=$(curl -Ls "https://cdn.amazonlinux.com/al2023/os-images/$distribution_release_al2023/kvm/SHA256SUMS" | awk -F '[[:space:]]+' '{print $2}')

curl -OL https://cdn.amazonlinux.com/al2023/os-images/$distribution_release_al2023/kvm/$filename

afbjorklund · 2024-08-10T10:29:32Z

The update procedure is a separate topic (and not a requirement), many others also lack a good method.

Automation for updating templates #1347

jandubois

Thanks, LGTM, but the file rename needs to be reflected in the README.

jandubois · 2024-08-28T20:55:24Z

examples/README.md

@@ -14,6 +14,7 @@ Distro:
 - [`almalinux-8`](./almalinux-8.yaml): AlmaLinux 8
 - [`almalinux-9`](./almalinux-9.yaml), `almalinux.yaml`: AlmaLinux 9
 - [`alpine`](./alpine.yaml): ☆Alpine Linux
+- [`amazonlinux2023.yaml`](./experimental/amazonlinux2023.yaml): [experimental] Amazon Linux 2023


The file has been renamed:

Suggested change

- [`amazonlinux2023.yaml`](./experimental/amazonlinux2023.yaml): [experimental] Amazon Linux 2023

- [`amazonlinux-2023.yaml`](./experimental/amazonlinux-2023.yaml): [experimental] Amazon Linux 2023

The file is renamed on disk, so you need to rename it here in the README too, to match the actual filename.

Also please squash all commits.

jandubois · 2024-08-29T15:36:35Z

You are missing the DCO sign-off. Also please squash commits!

examples/experimental/amazonlinux-2023.yaml

siennathesane · 2024-09-04T16:08:06Z

You are missing the DCO sign-off. Also please squash commits!

Done

jandubois

Thank you! Unfortunately not there yet:

The filenames in the README need to be updated to match the filenames on disk.
Adding a comment about the mountType would be nice.
Commits need to be squashed.

jandubois · 2024-09-05T03:59:07Z

examples/README.md

@@ -14,6 +14,7 @@ Distro:
 - [`almalinux-8`](./almalinux-8.yaml): AlmaLinux 8
 - [`almalinux-9`](./almalinux-9.yaml), `almalinux.yaml`: AlmaLinux 9
 - [`alpine`](./alpine.yaml): ☆Alpine Linux
+- [`amazonlinux2023.yaml`](./experimental/amazonlinux2023.yaml): [experimental] Amazon Linux 2023


The file is renamed on disk, so you need to rename it here in the README too, to match the actual filename.

Also please squash all commits.

examples/experimental/amazonlinux-2023.yaml

Signed-off-by: Sienna Satterwhite <[email protected]>

siennathesane · 2024-09-05T17:51:40Z

Commits need to be squashed.

Sorry, I didn't realise y'all use master so git reset --soft HEAD~$(git rev-list --count HEAD ^main) didn't catch everything. Addressed & fixed.

jandubois

Thanks!

PR looks good to me now, but while testing it on Sonoma with M1 I noticed that the mounts didn't actually work. Do they work for anybody else?

AkihiroSuda · 2024-09-18T22:33:27Z

@siennathesane Could you take a look at the mount issue?

siennathesane · 2024-09-23T18:40:51Z

@siennathesane Could you take a look at the mount issue?

This PR has been enough effort just to share an experimental example. I think it's unclear to me what the purpose of examples are if there's such a high bar to share something that's also experimental. The intent of this PR was to share an example of what an AWS config could look like, because it's my understanding that these are examples, esp experimental ones.

At this point if there's a reason not to merge, then go ahead and close the PR, but I'm not going to spend any more time on this.

AkihiroSuda · 2024-10-02T05:59:22Z

This PR has been enough effort just to share an experimental example. I think it's unclear to me what the purpose of examples are if there's such a high bar to share something that's also experimental. The intent of this PR was to share an example of what an AWS config could look like, because it's my understanding that these are examples, esp experimental ones.

"examples" have been renamed to "templates" in #1679 to clarify that they are expected to be useful OOTB, but the git repo still uses examples so as to keep hyperlinks alive.

The templates, especially experimental ones, may still have non-functional features.
However, such a non-functionality has to be explained in the comment lines of the yaml.

kikokikok · 2024-10-14T16:44:44Z

I've hit the same issue doing it from scratch before landing here...
could someone help me with where to look for ?
so far i've been able to see that

Cloud-init v. 22.2.2 running 'modules:config' at Mon, 14 Oct 2024 16:15:35 +0000. Up 9.95 seconds.
Cloud-init v. 22.2.2 running 'modules:final' at Mon, 14 Oct 2024 16:15:35 +0000. Up 10.15 seconds.
+ LIMA_CIDATA_MNT=/mnt/lima-cidata
+ LIMA_CIDATA_DEV=/dev/disk/by-label/cidata
+ mkdir -p -m 700 /mnt/lima-cidata
+ mount -o ro,mode=0700,dmode=0700,overriderockperm,exec,uid=0 /dev/disk/by-label/cidata /mnt/lima-cidata
+ export LIMA_CIDATA_MNT
+ exec /mnt/lima-cidata/boot.sh
LIMA 2024-10-14T18:15:35+02:00| Executing /mnt/lima-cidata/boot/00-alpine-user-group.sh
LIMA 2024-10-14T18:15:35+02:00| Executing /mnt/lima-cidata/boot/00-modprobe.sh
Loading kernel module "fuse"
Loading kernel module "tun"
Loading kernel module "tap"
Loading kernel module "bridge"
Loading kernel module "veth"
Loading kernel module "ip_tables"
Loading kernel module "ip6_tables"
Loading kernel module "iptable_nat"
Loading kernel module "ip6table_nat"
Loading kernel module "iptable_filter"
Loading kernel module "ip6table_filter"
Loading kernel module "nf_tables"
Loading kernel module "x_tables"
Loading kernel module "xt_MASQUERADE"
Loading kernel module "xt_addrtype"
Loading kernel module "xt_comment"
Loading kernel module "xt_conntrack"
Loading kernel module "xt_mark"
Loading kernel module "xt_multiport"
Loading kernel module "xt_nat"
Loading kernel module "xt_tcpudp"
Loading kernel module "overlay"
LIMA 2024-10-14T18:15:35+02:00| Executing /mnt/lima-cidata/boot/00-reboot-if-required.sh
+ command -v dnf
+ dnf -h needs-restarting
+ dnf needs-restarting -r
LIMA 2024-10-14T18:15:36+02:00| Executing /mnt/lima-cidata/boot/01-alpine-ash-as-bash.sh
LIMA 2024-10-14T18:15:36+02:00| Executing /mnt/lima-cidata/boot/02-wsl2-setup.sh
LIMA 2024-10-14T18:15:36+02:00| Executing /mnt/lima-cidata/boot/04-persistent-data-volume.sh
+ test -f /etc/alpine-release
+ exit 0
LIMA 2024-10-14T18:15:36+02:00| Executing /mnt/lima-cidata/boot/05-lima-disks.sh
+ test 0 -gt 0
+ exit 0
LIMA 2024-10-14T18:15:36+02:00| Executing /mnt/lima-cidata/boot/05-lima-mounts.sh
+ [[ vz == \v\z ]]
+ [[ virtiofs == \v\i\r\t\i\o\f\s ]]
+ '[' -d /sys/fs/selinux ']'
++ grep -n virtiofs
++ cut -d: -f1
LIMA 2024-10-14T18:15:36+02:00| Executing /mnt/lima-cidata/boot/05-rosetta-volume.sh
+ '[' true '!=' true ']'
+ '[' -f /etc/alpine-release ']'
+ binfmt_entry=/proc/sys/fs/binfmt_misc/rosetta
+ binfmtd_conf=/usr/lib/binfmt.d/rosetta.conf
+ '[' true = true ']'

I have tried adding

provision:
- mode: boot
  script: |
    # Load the virtiofs module at boot
    modprobe virtiofs
    # Ensure the module loads on every boot by adding it to the modules-load.d directory
    echo "virtiofs" > /etc/modules-load.d/virtiofs.conf

    #disable SELinux
    grubby --update-kernel ALL --args selinux=0

but unfortunately, it seems like the boot step is executed after the mount ?
Sorry my I don't have the knowledge depth needed to get this done. Willing to help though.

Thanks for any potential advice from someone.

kikokikok · 2024-10-14T19:10:26Z

Small update here

2024-10-14 16:55:05,857 - cc_mounts.py[DEBUG]: mounts configuration is [['vz-rosetta', '/mnt/lima-rosetta', 'virtiofs', 'defaults', '0', '0'], ['mount0', '/Users/christian.klat', 'virtiofs', 'rw,nofail', '0', '0'], ['mount1', '/tmp/lima', 'virtiofs', 'rw,nofail', '0', '0']]
2024-10-14 16:55:05,860 - util.py[DEBUG]: backgrounded Resizing took 0.006 seconds
2024-10-14 16:55:05,857 - util.py[DEBUG]: Reading from /etc/fstab (quiet=False)
2024-10-14 16:55:05,863 - util.py[DEBUG]: Read 217 bytes from /etc/fstab
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: Attempting to determine the real name of vz-rosetta
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: changed vz-rosetta => None
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: Ignoring nonexistent named mount vz-rosetta
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: Attempting to determine the real name of mount0
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: changed mount0 => None
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: Ignoring nonexistent named mount mount0
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: Attempting to determine the real name of mount1
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: changed mount1 => None
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: Ignoring nonexistent named mount mount1
2024-10-14 16:55:05,863 - cc_mounts.py[DEBUG]: Attempting to determine the real name of ephemeral0
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: changed default device ephemeral0 => None
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: Ignoring nonexistent default named mount ephemeral0
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: Attempting to determine the real name of swap
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: changed default device swap => None
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: Ignoring nonexistent default named mount swap
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: Skipping nonexistent device named None
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: Skipping nonexistent device named None
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: Skipping nonexistent device named None
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: no need to setup swap
2024-10-14 16:55:05,864 - cc_mounts.py[DEBUG]: No modifications to fstab needed

Seems like the cc_mounts.py is failing at performing the mounts.

In this run I was able to make sure virtiofs is loaded a reboot happened and then we have this issue.

AkihiroSuda reviewed Aug 7, 2024

View reviewed changes

examples/amazonlinux2023.yaml Outdated Show resolved Hide resolved

AkihiroSuda reviewed Aug 7, 2024

View reviewed changes

siennathesane force-pushed the patch-1 branch from 0426f90 to e50f072 Compare August 8, 2024 19:21

siennathesane requested a review from AkihiroSuda August 8, 2024 19:21

afbjorklund reviewed Aug 9, 2024

View reviewed changes

examples/experimental/amazonlinux2023.yaml Outdated Show resolved Hide resolved

siennathesane requested review from jandubois and afbjorklund August 12, 2024 14:21

jandubois requested changes Aug 28, 2024

View reviewed changes

afbjorklund reviewed Aug 30, 2024

View reviewed changes

examples/experimental/amazonlinux-2023.yaml Show resolved Hide resolved

siennathesane force-pushed the patch-1 branch from 6c4f51f to 57b88cd Compare September 4, 2024 16:07

jandubois requested changes Sep 5, 2024

View reviewed changes

siennathesane force-pushed the patch-1 branch from 57b88cd to ad4a04e Compare September 5, 2024 17:49

added amazonlinux-2023.yaml to examples

45865f7

Signed-off-by: Sienna Satterwhite <[email protected]>

siennathesane force-pushed the patch-1 branch from ad4a04e to 45865f7 Compare September 5, 2024 17:50

jandubois approved these changes Sep 5, 2024

View reviewed changes

jandubois added this to the v1.0 milestone Sep 5, 2024

AkihiroSuda removed this from the v1.0 milestone Oct 2, 2024

AkihiroSuda closed this Oct 2, 2024

	- [`amazonlinux2023.yaml`](./experimental/amazonlinux2023.yaml): [experimental] Amazon Linux 2023
	- [`amazonlinux-2023.yaml`](./experimental/amazonlinux-2023.yaml): [experimental] Amazon Linux 2023

Create amazonlinux2023 template #2537

Create amazonlinux2023 template #2537

Conversation

siennathesane commented Aug 7, 2024

jandubois commented Aug 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afbjorklund Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

afbjorklund Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afbjorklund commented Aug 8, 2024

siennathesane commented Aug 8, 2024

siennathesane commented Aug 8, 2024

afbjorklund commented Aug 9, 2024

pendo324 commented Aug 9, 2024 • edited Loading

afbjorklund commented Aug 10, 2024

jandubois left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jandubois commented Aug 29, 2024

siennathesane commented Sep 4, 2024

jandubois left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siennathesane commented Sep 5, 2024

jandubois left a comment

Choose a reason for hiding this comment

AkihiroSuda commented Sep 18, 2024

siennathesane commented Sep 23, 2024

AkihiroSuda commented Oct 2, 2024

kikokikok commented Oct 14, 2024

kikokikok commented Oct 14, 2024

afbjorklund Aug 30, 2024 •

edited

Loading

afbjorklund Aug 30, 2024 •

edited

Loading

pendo324 commented Aug 9, 2024 •

edited

Loading