-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cidata should respect DNS settings in lima.yaml #1962
Conversation
from the log, the "debian" integration test failed on phase 2 (test after a restarting), the first phase run successfully, anyway pls double check, thanks
|
Thanks, but please sign the commit for DCO (run |
I have signed the commit, please review |
@neowu Changes looks good. Basically we are giving priority to dns first. Now am just thinking why not support dns as a secondary ones. We always use slirp dns, additional to it we also use dns if its configured. This way slirp also will be there and custom DNS also can be configured. @AkihiroSuda what do you think about this ?? I believe this was the intention to dns property itself. |
No, this is not how DNS should be configured. You normally have multiple redundant DNS servers in case one of them is unavailable (e.g. because of maintenance). They could also be load-balancing. But they are not used as fallback if one DNS doesn't recognize a name. So if e.g. one DNS has additional entries for a VPN, and the other one doesn't, then it is random if the VPN names will resolve. The resolver should pick one DNS at random, and only try another one if the first one doesn't respond within a timeout. It will not retry if it got a NOTFOUND response. Different resolver implementations may implement things differently though, e.g. the musl implementation does send requests to multiple servers in parallel and then picks the first one to answer (which still could be NXDOMAIN, failing the lookup). So in general it is a bad idea to configure multiple DNS servers unless they cover exactly the same domains. |
Signed-off-by: Neo Wu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
fixes for #1940