Don't delete local socket when reverse #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually we should delete the remote socket, otherwise restart fails. WARN[0031] [hostagent] Failed to set up forward from "/var/tmp/docker.sock" (guest) to "/var/run/docker.sock" (host) EDIT: notice that the error message (for fail) was wrong as well, we're forwarding from host to guest (with reverse) |
afbjorklund
force-pushed
the
reverse-remove
branch
2 times, most recently
from
c187e28 to
7ac98b9
Compare
AkihiroSuda
reviewed
Aug 11, 2023
|
Rebasing may fix the CI failure |
When we are forwarding a local socket, we should not delete it. Doing so would interrupt the local service, if delete succeeds. Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
reverse-remove
branch
from
7ac98b9 to
05cff79
Compare
AkihiroSuda
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are forwarding a local socket, we should not delete it.
Theoretically we could delete the remote socket, if it exists.
Closes #1724