Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: use yq's indentation style #1537

Closed
wants to merge 1 commit into from

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented May 12, 2023

Fix #1389 so that we can eventually automate updating yamls (#1347) using yq.

Use git show --ignore-all-space --ignore-blank-lines to review this commit.

diff --git a/.yamllint b/.yamllint
index a7c8c3f..20183f4 100644
--- a/.yamllint
+++ b/.yamllint
@@ -3,8 +3,6 @@
 extends: default
 
 rules:
-  indentation:
-    indent-sequences: false
   truthy:
     allowed-values: ['true', 'false', 'on', 'off']
   comments-indentation: disable

@AkihiroSuda AkihiroSuda added this to the v0.16.0 milestone May 12, 2023
Fix issue 1389 so that we can eventually automate updating yamls (issue 1347) using yq.

Use `git show --ignore-all-space --ignore-blank-lines` to review this commit.

Signed-off-by: Akihiro Suda <[email protected]>
@afbjorklund
Copy link
Member

afbjorklund commented May 12, 2023

Since @jandubois feels strongly about the indentation, I would rather patch go-yaml.

#1389 (comment)

There really should be such a preference in yq, to allow both type of sequence indent...

       prefs := yqlib.NewDefaultYamlPreferences()
       prefs.CompactSequenceIndent = true

@AkihiroSuda AkihiroSuda removed this from the v0.16.0 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

templates: use yq's indentation style
2 participants