fix unclean stop for vz driver #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jan 22, 2023
pkg/vz/vz_driver_darwin.go
Outdated
| } | ||
|
|
||
| return nil | ||
| return errors.New("VZ CanRequestStop is not supported") |
There was a problem hiding this comment.
Suggested change
| return errors.New("VZ CanRequestStop is not supported") | |
| return errors.New("vz: CanRequestStop is not supported") |
AkihiroSuda
previously approved these changes
Jan 22, 2023
yes, i believe. This might even be the cause for factory-reset required for some cases. |
Signed-off-by: Balaji Vijayakumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1313
Why this change ?
lima hostagent is terminating before the vm is fully stopped. Due to this there were disk corruptions.
This PR adds support for waiting for the state change to complete before closing hostagent