Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: Promote EL9 from experimental #1120

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

AkihiroSuda
Copy link
Member

  • Moved rocky.yaml to rocky-8.yaml
  • Moved experimental/rocky-9.yaml to rocky-9.yaml
  • Symlinked rocky-9.yaml to rocky.yaml

Same for almalinux, oraclelinux, and centos-stream too.

EL8 are now "soft" deprecated as they are known not to work on M1 (#841). If the issue is not going to be fixed in EL 8.7, maybe we should officially deprecate EL8.

Fix #1099

@AkihiroSuda AkihiroSuda added impact/changelog guest/el8 Guest: CentOS 8 / Rocky Linux 8 / Alma Linux 8 guest/el9 labels Oct 18, 2022
@AkihiroSuda AkihiroSuda added this to the v0.13.0 milestone Oct 18, 2022
@AkihiroSuda AkihiroSuda force-pushed the move-el9-out-of-experimental branch from 9058f58 to 86af389 Compare October 18, 2022 06:36
@AkihiroSuda AkihiroSuda requested a review from jandubois October 19, 2022 03:19
jandubois
jandubois previously approved these changes Oct 19, 2022
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm wondering though if each section in examples/README.md shouldn't be sorted alphabetically, just for easier browsability.

At first I was irritated that the foo-9 distros are sorted before foo-8, but then noticed that a couple others are also in non-alpha-order. I assume it is meant to show more important ones first, but then ubuntu is listed all the way at the bottom in Distros (and vmnet is all the way at the top for Others). I don't care too much, but personally would prefer all sections sorted by name.

- Moved `rocky.yaml` to `rocky-8.yaml`
- Moved `experimental/rocky-9.yaml` to `rocky-9.yaml`
- Symlinked `rocky-9.yaml` to `rocky.yaml`

Same for almalinux, oraclelinux, and centos-stream too.

EL8 are now "soft" deprecated as they are known not to work on M1 (issue 841).
If the issue is not going to be fixed in EL 8.7, maybe we
should officially deprecate EL8.

Fix issue 1099

Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

Updated to sort the templates

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AkihiroSuda AkihiroSuda merged commit 1a56960 into lima-vm:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guest/el8 Guest: CentOS 8 / Rocky Linux 8 / Alma Linux 8 guest/el9 impact/changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote {rocky, almalinux, oracle, centos-stream}-9 from experimental
2 participants