-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aarch64 opensuse tumbleweed #1014
Add aarch64 opensuse tumbleweed #1014
Conversation
@@ -23,7 +23,7 @@ if [ "${LIMA_CIDATA_UDP_DNS_LOCAL_PORT}" -ne 0 ] || [ "${LIMA_CIDATA_TCP_DNS_LOC | |||
fi | |||
|
|||
# Install minimum dependencies | |||
if command -v apt-get >/dev/null 2>&1; then | |||
if hexdump -C -n 4 "$(command -v apt-get)" | grep -qF 'ELF' >/dev/null 2>&1; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a code comment to explain the background?
Thanks, but please sign the commit for DCO (run |
Signed-off-by: replicajune <[email protected]>
apt-get "command -v" detection matches on opensuse and runs a script that fails to run with some of the option used bellow. Signed-off-by: replicajune <[email protected]>
…r package managers Signed-off-by: replicajune <[email protected]>
hello @AkihiroSuda, thank you for the time you're spending on the PR, much appreciated :)
|
Thanks, but please use real name |
the name I use on github (and for other tech related stuff) comply with the definition of real name of DCO as far as I can see (https://github.com/cncf/foundation/blob/main/dco-guidelines.md: "Your real name is the name you convey to people in the community for them to use to identify you as you") is this ok for you ? |
Thanks, wasn't aware of that guideline.
Maybe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This merge request is related to the issue #1011 and is aiming at being able to user OpenSuse with the current script approach to package manager detection