Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 opensuse tumbleweed #1014

Merged
merged 3 commits into from
Aug 20, 2022
Merged

Add aarch64 opensuse tumbleweed #1014

merged 3 commits into from
Aug 20, 2022

Conversation

replicajune
Copy link
Contributor

This merge request is related to the issue #1011 and is aiming at being able to user OpenSuse with the current script approach to package manager detection

@@ -23,7 +23,7 @@ if [ "${LIMA_CIDATA_UDP_DNS_LOCAL_PORT}" -ne 0 ] || [ "${LIMA_CIDATA_TCP_DNS_LOC
fi

# Install minimum dependencies
if command -v apt-get >/dev/null 2>&1; then
if hexdump -C -n 4 "$(command -v apt-get)" | grep -qF 'ELF' >/dev/null 2>&1; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a code comment to explain the background?

@AkihiroSuda
Copy link
Member

Thanks, but please sign the commit for DCO
https://github.com/apps/dco

(run git commit -a -s --amend, and make sure that the Signed-off-by: NAME <EMAIL> line with your real name is included in the commit message)

apt-get "command -v" detection matches on opensuse and runs a script that
fails to run with some of the option used bellow.

Signed-off-by: replicajune <[email protected]>
@replicajune
Copy link
Contributor Author

hello @AkihiroSuda, thank you for the time you're spending on the PR, much appreciated :)

  • I've updated the two initial commits I made and signed them. It passes DCO now. Does it work for you ?
  • I've added a comment explaining the chained command in the script, I've also added a detail about why it's done and a link to this PR in case it can be reverted in the future

@AkihiroSuda
Copy link
Member

Thanks, but please use real name

@replicajune
Copy link
Contributor Author

the name I use on github (and for other tech related stuff) comply with the definition of real name of DCO as far as I can see (https://github.com/cncf/foundation/blob/main/dco-guidelines.md: "Your real name is the name you convey to people in the community for them to use to identify you as you")

is this ok for you ?

@AkihiroSuda
Copy link
Member

the name I use on github (and for other tech related stuff) comply with the definition of real name of DCO as far as I can see (https://github.com/cncf/foundation/blob/main/dco-guidelines.md: "Your real name is the name you convey to people in the community for them to use to identify you as you")

Thanks, wasn't aware of that guideline.

is this ok for you ?

Maybe.
Opened cncf/toc#906 for confirmation about "pseudonyms"

@AkihiroSuda AkihiroSuda added this to the v0.11.4 milestone Aug 20, 2022
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit bc113ca into lima-vm:master Aug 20, 2022
@replicajune replicajune deleted the add-aarch64-opensuse-tumbleweed branch August 21, 2022 17:07
@AkihiroSuda AkihiroSuda linked an issue Sep 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add opensuse-tumbleweed for aarch64
2 participants