Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lima-init.sh yaml parsing more robust #126

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Make lima-init.sh yaml parsing more robust #126

merged 1 commit into from
Mar 9, 2024

Conversation

jandubois
Copy link
Member

Parsing the mounts and ca_certs sections no longer need an empty line to signal the end of the section; they will now detect when the next line can no longer be part of the block.

@jandubois
Make lima-init.sh yaml parsing more robust
46e5baa 
Parsing the `mounts` and `ca_certs` sections no longer need
an empty line to signal the end of the section; they will now
detect when the next line can no longer be part of the block.

Signed-off-by: Jan Dubois <[email protected]>
@jandubois jandubois requested a review from AkihiroSuda March 9, 2024 03:29
@jandubois jandubois mentioned this pull request Mar 9, 2024
Merged
AkihiroSuda
AkihiroSuda approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's merge this, but we should consider installing yq or something

@AkihiroSuda AkihiroSuda merged commit 5a09f68 into lima-vm:main Mar 9, 2024
2 checks passed
@jandubois jandubois deleted the mounts branch March 9, 2024 07:27
@jandubois
Copy link
Member Author

Thanks, let's merge this, but we should consider installing yq or something

Yeah, or just use cloud-init. I wrote lima-init in shell/awk when the whole ISO was just 30MB, and adding cloud-init made it grow to 60MB (mostly due to adding Python). But the std image is now 70-80MB, so maybe switching to cloud-init is reasonable (yq also adds 4MB compressed).

Anyways, for now it works...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jandubois @AkihiroSuda