fix(mkimage): log console boot messages to hvc0 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VZ has support for serial console logging but the device is different from Qemu. VZ uses the hypervisor virtual console device instead. This change modifies the bootloader to add hvc0 as a device to log console messages to on boot. Note this has no effect on the tty serial logging. Issue: lima-vm/lima#1659 Signed-off-by: Ryan Currah <[email protected]>
jandubois
approved these changes
Sep 2, 2023
|
I assume you wanted a release with this change: https://github.com/lima-vm/alpine-lima/releases/tag/v0.2.32 |
|
Thanks @jandubois and @AkihiroSuda! Just a note on functionality in the Alpine Lima image. Because hvc0 is not configured as the primary console, messages to hvc0 will only work during boot. It's better then no messages, but maybe in the future we could revisit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VZ has support for serial console logging but the device is different from Qemu. VZ uses the hypervisor virtual console device instead. This change modifies the bootloader to add hvc0 as a device to log console messages to on boot.
Note this has no effect on the tty serial logging.
Issue: lima-vm/lima#1659