Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make State::panic unsafe #24

Closed
wants to merge 1 commit into from
Closed

Make State::panic unsafe #24

wants to merge 1 commit into from

Conversation

cjcole
Copy link

@cjcole cjcole commented Mar 22, 2015

$ cargo --version && rustc --version
cargo 0.0.1-pre-nightly (e689383 2015-03-16) (built 2015-03-16)
rustc 1.0.0-nightly (ecf8c64e1 2015-03-21) (built 2015-03-21)

@lilyball
Copy link
Owner

What's the motivating reason for this change?

@cjcole
Copy link
Author

cjcole commented Mar 23, 2015

Unless I'm mistaken, it doesn't build with the latest Rust nightly otherwise.

BTW, thanks for the library. I use it pretty extensively (without problems so far).

On 3/23/2015 at 1:14 PM, "Kevin Ballard" [email protected] wrote:

What's the motivating reason for this change?


Reply to this email directly or view it on GitHub:
#24 (comment)

@lilyball
Copy link
Owner

Travis has been failing for the past couple of days with a curious error about an empty -L flag. I haven't looked into it yet. I admit I haven't built locally for a few days, but I hadn't had an error with this before. I'll check today (and see if I can't figure out what's going on with Travis).

@cjcole
Copy link
Author

cjcole commented Mar 23, 2015

Ok. I built locally and it failed. After the change in this pull request, it worked. Verification is always welcome, though.

I noticed the Travis complaint, too. No idea.

On 3/23/2015 at 1:45 PM, "Kevin Ballard" [email protected] wrote:

Travis has been failing for the past couple of days with a curious
error about an empty -L flag. I haven't looked into it yet. I
admit I haven't built locally for a few days, but I hadn't had an
error with this before. I'll check today (and see if I can't
figure out what's going on with Travis).


Reply to this email directly or view it on GitHub:
#24 (comment)

@lilyball
Copy link
Owner

Looks like rust-lang/rust#23452 made safe fns no longer subtypes of unsafe fns.

@lilyball
Copy link
Owner

I ended up making a larger change that encompasses this one. Committed as 73b912f. Thanks!

@lilyball lilyball closed this Mar 23, 2015
@cjcole
Copy link
Author

cjcole commented Mar 23, 2015

Great, thanks.

On 3/23/2015 at 4:39 PM, "Kevin Ballard" [email protected] wrote:

I ended up making a larger change that encompasses this one.
Committed as 73b912f. Thanks!


Reply to this email directly or view it on GitHub:
#24 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants