Repository navigation
[Bugfix] 修复 Mooncake Prefill abort 清理缺少 waiting_timeout 导致崩溃 - #41
Merged
lihenga merged 1 commit intoOct 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
修复 Mooncake Prefill 在取消请求后的清理异常:
finish_drained_abort()计算终态记录 TTL 时读取waiting_timeout,但该属性此前只在 Decode manager 初始化。Prefill 因此抛出 AttributeError,后续 KV 释放被中断,空闲池检查失败并导致 Scheduler 退出。2026-10-21 的实际日志先记录压测命令 status=-9,随后 Decode AbortReq,再出现上述 Prefill 异常;本 PR 修复清理路径,不推断或修改 SIGKILL 的来源。
Modifications
仅在 Mooncake Prefill manager 启动传输线程前,从既有 SGLANG_DISAGGREGATION_WAITING_TIMEOUT 配置初始化 waiting_timeout,保持终态记录 TTL 的 max(300, bootstrap_timeout, waiting_timeout) 语义。无新配置、依赖或协议改动。
与 #38 的关系:feature/optimize_main 已合入 #38 的 finish_drained_abort 逻辑。本 PR 独立补齐该逻辑依赖的 Prefill 配置;仅改动初始化,可直接 cherry-pick 到指定星火分支。
Accuracy Tests
Speed Tests and Profiling
未运行性能或模型精度 benchmark;改动仅在 Prefill manager 启动时读取已有配置。
Checklist
AI 辅助:Codex 完成实现和有界差异自查;维护者人工 review 待完成。
Review and Merge Process
按维护者在本任务中的明确授权合并。