Skip to content

Update deps#848

Merged
DanTulovsky merged 2 commits into
mainfrom
update_deps
May 12, 2025
Merged

Update deps#848
DanTulovsky merged 2 commits into
mainfrom
update_deps

Conversation

@DanTulovsky
Copy link
Copy Markdown
Contributor

Description: Update dependencies.

@DanTulovsky DanTulovsky requested a review from akehlenbeck May 12, 2025 17:15
@akehlenbeck
Copy link
Copy Markdown
Contributor

For these compilation errors

# github.com/lightstep/otel-launcher-go/lightstep/sdk/internal
Error: lightstep/sdk/internal/common.go:221:11: settings.MetricsLevel undefined (type component.TelemetrySettings has no field or method MetricsLevel)
Error: lightstep/sdk/internal/common.go:222:11: settings.LeveledMeterProvider undefined (type component.TelemetrySettings has no field or method LeveledMeterProvider)

I'm pretty sure you can just delete those two lines. They appear to reference fields of the structure that were deprecated and deleted in these two upstream changes:

open-telemetry/opentelemetry-collector#12189

open-telemetry/opentelemetry-collector#11811

Copy link
Copy Markdown
Contributor

@akehlenbeck akehlenbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if there aren't any more errors after you delete those two lines, LGTM)

@DanTulovsky DanTulovsky merged commit e0e8b9b into main May 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants