Add a Bazel build file for lightstep-tracer-cpp.#85
Merged
rnburn merged 1 commit intolightstep:masterfrom Nov 10, 2017
Merged
Conversation
This lets projects that use the Bazel build system (http://bazel.build) more easily depend on Lightstep's C++ tracer. To generate `config.h` and `version.h`, the config shells out to `cmake` instead of duplicating the existing version definitions from `CMakeLists.txt`. The unprefixed `collector.pb.h` includes and vendoring of `googleapis` gave me some trouble, so I used `local_repository` to treat those as separate Bazel workspaces. We should be able to clean that up when `lightstep-tracer-common` gets its own BUILD files.
Contributor
|
Thank you. I'll do some rearranging to make this more bazel-friendly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets projects that use the Bazel build system (http://bazel.build)
more easily depend on Lightstep's C++ tracer.
To generate
config.handversion.h, the config shells out tocmakeinstead of duplicating the existing version definitions from
CMakeLists.txt.The unprefixed
collector.pb.hincludes and vendoring ofgoogleapisgaveme some trouble, so I used
local_repositoryto treat those as separateBazel workspaces. We should be able to clean that up when
lightstep-tracer-commongets its own BUILD files.