Repository navigation
Implement Spotlight system templates and edge-case structure (LS-1718) - #7
Conversation
Add templates/front-page.html (curated homepage: hero, "Explore by topic", "Latest news", dashboard-CTA banner, "Special Projects", provincial coverage + newsletter, "Perspectives" — each a structural placeholder pending pattern-authoring work, no core/query block), templates/search.html (reuses the home/archive card-grid structure with an inherited query bound to the search results, no topic-filter pills), and templates/404.html (calm message plus a search form, no query loop). templates/index.html left unmodified as the required fallback-of-last-resort. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note
|
There was a problem hiding this comment.
Pull request overview
Adds the remaining “system/edge-case” templates to complete the Spotlight template hierarchy workstream (LS-1718), wiring them into the existing shared template parts and documenting the change in OpenSpec + changelog.
Changes:
- Added three new templates: curated front page (
front-page.html), search results (search.html), and 404 fallback (404.html). - Marked LS-1718 task group complete in the OpenSpec tasks list.
- Documented the new templates under
## [Unreleased]inCHANGELOG.md.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/front-page.html | New curated homepage template composed of clearly labelled structural placeholders. |
| templates/search.html | New search results template using an inherited query loop plus a search refinement form. |
| templates/404.html | New 404 template with a calm message and search form. |
| openspec/changes/spotlight-template-hierarchy/tasks.md | Marks LS-1718 tasks as completed. |
| CHANGELOG.md | Adds Unreleased entries documenting the new templates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Remove "authors" from the search placeholder text in search.html and 404.html — WordPress core search only covers post title/content, not author names, so the original copy was misleading - 404.html's "head back to our homepage" instruction now has a real, functional link (a button to /) instead of promising a destination with nothing to click Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Remove "authors" from the search placeholder in home.html and archive.html — WordPress core search only covers post title/content, not author names, so the original copy was misleading. Same fix already applied to search.html/404.html on the LS-1718 branch following Copilot's review feedback on PR #7. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ts-and-wrappers' into feat/ls-1718-system-templates-and-edge-case-structure # Conflicts: # CHANGELOG.md
…ts-and-wrappers' into feat/ls-1718-system-templates-and-edge-case-structure # Conflicts: # CHANGELOG.md
b3b558f
into
feat/ls-1715-shared-template-parts-and-wrappers
Description
This branch defines the last three templates in Spotlight's core hierarchy — the curated homepage (
front-page.html), search results (search.html), and the 404 fallback (404.html). It closes LS-1718, building directly on the shared template parts (header,trust-bar,footer) merged via LS-1715/#4.Changes
templates/front-page.html(new): the curated homepage — hero, "Explore by topic," "Latest news," a dashboard-CTA banner, "Special Projects," provincial coverage + newsletter, and "Perspectives" sections. Each section is a labeled structural placeholder (heading + placeholder text), not real pattern content — actual pattern authoring is explicitly out of this branch's scope, perdesign.md's non-goals, since nopatterns/directory exists yet in this theme. Nocore/queryblock, distinguishing it structurally fromhome.htmltemplates/search.html(new): reuses the same card-grid structure ashome.html/archive.html— an inheritedcore/queryblock bound to the actual search results, acore/query-titleshowing the search term, and a search box for refining — but no topic-filter pills, since search results aren't filtered by topictemplates/404.html(new): a calm "Page not found" message plus a search box, no post query loop — consistent with the "calmer editorial hierarchy" acceptance criterion rather than a jarring dead endtemplates/index.html: confirmed left unmodified, as WordPress's required fallback-of-last-resorttheme.jsoncustomTemplates: evaluated, not needed — standard hierarchy slugs get sensible default editor labels automatically[Unreleased]Files Modified
Source files:
templates/front-page.html— newtemplates/search.html— newtemplates/404.html— newCHANGELOG.md— new[Unreleased]entriesPlanning/spec files:
openspec/changes/spotlight-template-hierarchy/tasks.md— task group 4 (LS-1718) checkboxes marked complete; this is the final sibling branch, so all four groups of the OpenSpec change are now implementedKey Improvements
front-page.htmlis now what actually renders at the site root (WordPress falls back to it ahead ofhome.html/index.html), unblocking real front-end verification of every base style shipped since LS-1711 — the original motivation for this whole template-hierarchy effortsearch.html/404.htmldeliberately introduce zero new visual vocabulary — reusing the existing card-grid-and-chrome structure keeps them consistent and low-risk given neither has a reviewed design sourceRelated Issues
Closes LS-1718 — define Spotlight system templates and edge-case structure
Part of LS-1705 — define Spotlight template hierarchy and core template parts (parent issue; this is the last of its four sub-issues — LS-1714/1715/1716/1717 — to reach a PR)
Testing
npm run schema:validatepassesnpm run theme:validatepasses (required files, placeholder tokens, text-domain consistency)front-page.htmlnow renders for the site root,search.htmland404.htmlboth render without fatal errorstemplates/index.htmlis byte-for-byte unchangedDeployment Notes
feat/ls-1715-shared-template-parts-and-wrappers, notdevelop— it depends on the shared parts from Implement Spotlight shared template parts (LS-1715) #4 and should not be merged before itfront-page.html's section placeholders are intentionally unstyled/generic — the real hero, card-row, and dashboard-banner patterns are follow-on work oncepatterns/exists in this themeChecklist
feat/ls-1715-shared-template-parts-and-wrappers)front-page.html,search.html,404.html