Skip to content

Conversation

@raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Nov 26, 2025

activate hermetic build on x86_64 platform

Summary by CodeRabbit

Chores

  • Updated build pipeline to support dependency prefetching, optional source-image generation, and hermetic (isolated) execution for multi-architecture builds.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'profile'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Two Tekton PipelineRun YAMLs add three new parameters: build-source-image ("true"), prefetch-input (JSON-like string referencing pip and requirements.txt), and hermetic ("true"), making them available to the pipeline invocation; no existing parameters were removed or renamed.

Changes

Cohort / File(s) Summary
Tekton PipelineRun parameter additions
.tekton/dataverse-exporter-pull-request.yaml, .tekton/dataverse-exporter-push.yaml
Adds three new PipelineRun spec.params: build-source-image set to the string "true", prefetch-input set to a JSON-like value referencing pip and requirements.txt, and hermetic set to the string "true". No parameters were removed or renamed.

Possibly related PRs

  • OLS-2114: Fix EC violations #33 — Directly modifies the same Tekton PipelineRun configs with identical parameter additions for source image building, prefetch configuration, and hermetic mode execution.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'LCORE-858 konflux: hermetic build' directly and clearly summarizes the main change—enabling hermetic build mode in the Tekton pipeline configuration, which aligns with the PR description and file changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a120d8 and a850258.

📒 Files selected for processing (2)
  • .tekton/dataverse-exporter-pull-request.yaml (1 hunks)
  • .tekton/dataverse-exporter-push.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .tekton/dataverse-exporter-pull-request.yaml
  • .tekton/dataverse-exporter-push.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Red Hat Konflux / lightspeed-to-dataverse-exporter-on-pull-request
  • GitHub Check: build-pr
  • GitHub Check: Konflux kflux-prd-rh02 / dataverse-exporter-on-pull-request

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Haoyu Sun <[email protected]>
@raptorsun
Copy link
Contributor Author

the job Red Hat Konflux / dataverse-exporter-on-pull-request is wrongly triggered, please override it.

@onmete
Copy link
Collaborator

onmete commented Nov 26, 2025

/lgtm

@onmete onmete merged commit 92fe242 into lightspeed-core:main Nov 26, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants