-
Notifications
You must be signed in to change notification settings - Fork 58
LCORE-423: Add a section how to run lightspeed-stack image on MacOS #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughREADME.md updated with macOS-specific guidance for ARM64 container building, noting incompatibility of podman compose emulation and recommending docker compose instead. Library Mode section header standardized from inline label to formal markdown header. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
598-608: Clarify what "will not work" means.Line 600 uses vague language about podman compose incompatibility. Specify the actual failure mode—does emulation hang, error out, produce incorrect results, or cause performance issues? This helps macOS users quickly identify if they're experiencing the described problem and know how to resolve it.
Consider updating line 600 to something like:
-Emulation of platform amd64 will not work with `podman compose up --build` command. +Emulation of platform amd64 on macOS with `podman compose up --build` may fail or hang.Or provide more specific details if you know the exact error behavior observed during testing.
634-642: Explain the mount option difference between Library Mode sections.The macOS section (lines 636–639) uses
:ro(read-only) mounts, while the generic example above it (lines 628–629) uses:Z(SELinux relabel). Adding a brief comment explaining why macOS requires different mount flags would help users understand when to use each and prevent copy/paste errors across different platforms.Consider adding a clarifying comment:
#### macOS +<!-- Use read-only (`:ro`) mounts on macOS instead of SELinux context (`:Z`) --> ```bash podman run \Or update the documentation narrative above the code block to note the platform-specific mount difference.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
- GitHub Check: build-pr
- GitHub Check: e2e_tests (azure)
- GitHub Check: e2e_tests (ci)
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Edit README file to fix macOS image building guide
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
I have tested image building and run on macOS Tahoe 26.1
Summary by CodeRabbit