Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Oct 9, 2025

Description

LCORE-642: better run.yaml structure

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #LCORE-642

Summary by CodeRabbit

  • Refactor

    • Standardized configuration to explicit provider blocks across all sections for consistency and easier management.
    • Updated model definitions to use model_id/model_type and centralized embedding metadata.
    • Consolidated Braintrust/OpenAI credentials within the provider configuration.
    • Switched vector configuration to a FAISS provider and aligned references accordingly.
    • Removed redundant inline configs and aligned related sections.
  • Chores

    • Migrated run configuration to the new provider-based structure with no expected functional changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Restructured run.yaml to use explicit provider blocks with provider_id/provider_type across multiple sections, relocated configs under their providers, updated model definitions (model_id/model_type, metadata), adjusted credentials placement (e.g., braintrust/openai), and aligned vector_io/faiss and related references to the new provider-based structure.

Changes

Cohort / File(s) Summary of Changes
Provider-based config refactor
run.yaml
Centralized scattered inline configs into explicit provider blocks (files, meta-reference, datasetio, eval, post_training, safety, scoring, telemetry, tool_runtime, vector_io). Added provider_id/provider_type, nested configs under providers, moved braintrust/openai key into braintrust provider, updated models to model_id/model_type with metadata, aligned vector_io/faiss and references.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

A rabbit rewired the map tonight,
Providers in rows, all configs tight.
Keys tucked snug where they belong,
Models sing a cleaner song.
FAISS hums low, vectors in line—
Hop, hop, ship it—everything’s fine! 🐇✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44435d2 and f80f24e.

📒 Files selected for processing (1)
  • run.yaml (4 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 1ef6137 into lightspeed-core:main Oct 9, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant