-
Notifications
You must be signed in to change notification settings - Fork 22
use absolute imports #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR converts relative imports to absolute package imports across the codebase and updates several package init modules to re-export additional public symbols via all. No runtime logic or control flow changes are introduced. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (38)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-09-18T23:59:37.026ZApplied to files:
📚 Learning: 2025-07-16T12:07:29.169ZApplied to files:
🧬 Code graph analysis (35)src/lightspeed_evaluation/core/output/generator.py (3)
src/lightspeed_evaluation/core/system/validator.py (2)
src/lightspeed_evaluation/core/output/visualization.py (2)
src/lightspeed_evaluation/core/output/statistics.py (1)
src/lightspeed_evaluation/core/metrics/ragas.py (5)
src/lightspeed_evaluation/core/system/loader.py (1)
src/lightspeed_evaluation/core/output/__init__.py (3)
src/lightspeed_evaluation/core/embedding/manager.py (2)
src/lightspeed_evaluation/core/metrics/deepeval.py (3)
src/lightspeed_evaluation/core/script/__init__.py (2)
src/lightspeed_evaluation/pipeline/__init__.py (1)
src/lightspeed_evaluation/pipeline/evaluation/amender.py (3)
src/lightspeed_evaluation/core/metrics/script_eval.py (2)
src/lightspeed_evaluation/runner/evaluation.py (5)
src/lightspeed_evaluation/core/output/data_persistence.py (1)
src/lightspeed_evaluation/core/system/setup.py (1)
src/lightspeed_evaluation/pipeline/evaluation/processor.py (7)
src/lightspeed_evaluation/core/llm/manager.py (2)
src/lightspeed_evaluation/runner/__init__.py (2)
src/lightspeed_evaluation/core/metrics/manager.py (2)
src/lightspeed_evaluation/core/metrics/__init__.py (3)
src/lightspeed_evaluation/pipeline/evaluation/evaluator.py (10)
src/lightspeed_evaluation/core/metrics/custom.py (3)
src/lightspeed_evaluation/pipeline/evaluation/__init__.py (5)
src/lightspeed_evaluation/core/models/__init__.py (2)
src/lightspeed_evaluation/pipeline/evaluation/errors.py (1)
src/lightspeed_evaluation/core/__init__.py (5)
src/lightspeed_evaluation/core/system/env_validator.py (1)
src/lightspeed_evaluation/core/script/manager.py (1)
src/lightspeed_evaluation/core/api/client.py (3)
src/lightspeed_evaluation/core/embedding/ragas.py (1)
src/lightspeed_evaluation/pipeline/evaluation/pipeline.py (11)
src/lightspeed_evaluation/core/system/__init__.py (5)
src/lightspeed_evaluation/core/llm/__init__.py (6)
src/lightspeed_evaluation/core/api/__init__.py (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (32)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@VladimirKadlec @tisnik PTAL |
VladimirKadlec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you 👍
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use absolute imports instead of relative for better clarity of the code structure & avoid any potential conflict with python packages.
Summary by CodeRabbit
New Features
Refactor
Style