-
Notifications
You must be signed in to change notification settings - Fork 51
fix: use model card from pylate for upload to hub #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If you're generally okay with this PR, @NohTow, what do you think about testing this? We could address it by pushing to a private LightOnAI hf repo and then loading from it as a test case. Does that sound like a good idea to you? At least for main? |
|
Hello, I actually did not test pushing to hub the models trained, but the model card created locally during the saving seemed to be overwritten by our template, so the save function looks alright? I am trying to figure out what's wrong, let me know if I am missing something |
|
Actually I think I understand, the card was working before #87, where I removed the function to not override a function that has no change w.r.t ST and benefits from Tom's changes without doing anything, but there is a regression because it does not call our function anymore. |
|
No worries about the delay! I've submitted a PR for ST to improve this, as I share the same sentiment. ^^ I'll keep this PR open as an alternative in case it's rejected. If it's accepted, I'll repurpose this PR to integrate PyLate with my changes. |
|
@NohTow What do you think about merging this? It should fix the issue. I'll keep track of the pull request on the st library, and if it gets merged, I'll create a new PR to adopt the new approach. |
|
Yes it seems reasonable, it was like that before I tried to better extend ST so it is not a big issue! |
|
The changes have been merged into ST! Thanks a lot for your support, @NohTow! Looking forward to ST v4+ so we can bring this update to PyLate. Have a great weekend! |
This PR allows the use of push_to_hub with the PyLate template.
ST lib is importing its own create ModelCard function that is not getting overwritten by PyLate.