routerrpc: check payaddr before using for probing#9134
Merged
Roasbeef merged 4 commits intolightningnetwork:masterfrom Sep 26, 2024
Merged
routerrpc: check payaddr before using for probing#9134Roasbeef merged 4 commits intolightningnetwork:masterfrom
Roasbeef merged 4 commits intolightningnetwork:masterfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ellemouton
force-pushed
the
checkPayAddrBeforeDeref
branch
2 times, most recently
from
d937117 to
8976daa
Compare
Roasbeef
requested changes
Sep 24, 2024
ellemouton
force-pushed
the
checkPayAddrBeforeDeref
branch
from
d4580da to
766cf77
Compare
Since it is allowed to not be set and so can lead to nil deref panics if it is a pointer.
ellemouton
force-pushed
the
checkPayAddrBeforeDeref
branch
from
766cf77 to
d752ab0
Compare
Also add atomic start and stop vars to prevent close of a closed channel.
ellemouton
force-pushed
the
checkPayAddrBeforeDeref
branch
from
959a785 to
8663950
Compare
yyforyongyu
approved these changes
Sep 26, 2024
Member
yyforyongyu
left a comment
yyforyongyu
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
| // Start starts the service. | ||
| func (s *HtlcModificationInterceptor) Start() error { | ||
| if !s.started.CompareAndSwap(false, true) { | ||
| return nil |
Member
There was a problem hiding this comment.
nit: add debug log like others?
| if err := s.invoices.Stop(); err != nil { | ||
| srvrLog.Warnf("failed to stop invoices: %v", err) | ||
| } | ||
| if err := s.interceptableSwitch.Stop(); err != nil { |
This was referenced Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in other places where we extract and use the payment address from an invoice, we first check that it is set before dereferencing it.