rpc: fix ordering of feature bit check in rpcCommitmentType#9040
Merged
Roasbeef merged 1 commit intolightningnetwork:0-19-stagingfrom Aug 28, 2024
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
guggero
approved these changes
Aug 28, 2024
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Linter is unhappy, otherwise LGTM 🎉
yyforyongyu
approved these changes
Aug 28, 2024
|
|
||
| // TestRpcCommitmentType tests the rpcCommitmentType returns the corect | ||
| // commitment type given a channel type. | ||
| func TestRpcCommitmentType(t *testing.T) { |
Roasbeef
force-pushed
the
rpc-commit-type-bug-fix
branch
from
565e94f to
6e4439b
Compare
We need to check if it has a tapsript root first, as if it has a tapscript root, then it's also a taproot channel. By checking if it has a tapscript root first, we'll now display the proper commitment type for RPC responses.
Roasbeef
force-pushed
the
rpc-commit-type-bug-fix
branch
from
6e4439b to
97a5415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to check if it has a tapsript root first, as if it has a tapscript root, then it's also a taproot channel. By checking if it has a tapscript root first, we'll now display the proper commitment type for RPC responses.