Skip to content

mod: bump kvdb to v1.4.10#8959

Merged
guggero merged 3 commits intolightningnetwork:masterfrom
guggero:bump-kvdb
Aug 5, 2024
Merged

mod: bump kvdb to v1.4.10#8959
guggero merged 3 commits intolightningnetwork:masterfrom
guggero:bump-kvdb

Conversation

@guggero
Copy link
Collaborator

@guggero guggero commented Jul 31, 2024

To enable the changes from #8845, we need to use the new version of the kvdb submodule.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 31, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

We'll need to do this again soon though due to these:

@guggero
Copy link
Collaborator Author

guggero commented Jul 31, 2024

LGTM 🎉

We'll need to do this again soon though due to these:

* [multi: check leader status with our health checker to correctly shut down LND if network partitions #8938](https://github.com/lightningnetwork/lnd/pull/8938)

* [[wip] invoices: migrate KV invoices to native SQL #8831](https://github.com/lightningnetwork/lnd/pull/8831)

LGTM 🎉

We'll need to do this again soon though due to these:

* [multi: check leader status with our health checker to correctly shut down LND if network partitions #8938](https://github.com/lightningnetwork/lnd/pull/8938)

* [[wip] invoices: migrate KV invoices to native SQL #8831](https://github.com/lightningnetwork/lnd/pull/8831)

Ah, right. Thanks for the reminder. We can also keep this open and then bump everything at once. Just wanted to make sure I don't forget after merging #8845.

Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

guggero added 3 commits August 5, 2024 09:29
To support the new comma-separated list of etcd hosts in db.etcd.host,
we need to bump the `kvdb` submodule version.
This also fixes a leader election bug in the etcd code.
@guggero guggero changed the title mod: bump kvdb to v1.4.9 mod: bump kvdb to v1.4.10 Aug 5, 2024
@guggero
Copy link
Collaborator Author

guggero commented Aug 5, 2024

Included the bump to the version after #8938 was merged. Not going to wait for #8831 since that's still WIP.

@guggero guggero requested a review from bhandras August 5, 2024 08:34
@guggero guggero merged commit 7e1e054 into lightningnetwork:master Aug 5, 2024
@guggero guggero deleted the bump-kvdb branch August 5, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants