feature: advertise required feature bit for TLV onions #6336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we start to advertise the required feature bit for the new modern TLV onion format. In a future change, we'll remove the logic for being able to encode+encode the payload. For now, we still have tests that exercise being able to use the new and old formats (as well as both of them in a single route), so we'll continue to retain that behavior for now. Implements lightning/bolts#962.
Roasbeef
force-pushed
the
mandatory-tlv-onion
branch
from
aff2913
to
f77fb99
Compare
ellemouton
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
LGTM 👍
Just for completeness sake, the one other place I think we can maybe change to using the required bit instead of the optional bit in this pr (instead of waiting for the follow-up pr where we remove all the legacy code for the optional bit) is for when we create the JIT keysend and AMP invoices. currently we just put in the optional feature bit there & persist those invoices.
|
So instead, we might want to leave the feature bit as is, and modify the |
|
Made this PR to implement the change above: #6385 |
|
Moving this to 0.16 given that we're introducing behavior in 0.14.3 to stop allowing the legacy onions to be sent at all. |
saubyk
added
P3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we start to advertise the required feature bit for the
new modern TLV onion format. In a future change, we'll remove the logic
for being able to encode+encode the payload. For now, we still have
tests that exercise being able to use the new and old formats (as well
as both of them in a single route), so we'll continue to retain that
behavior for now.
Implements lightning/bolts#962.